From: Eric Dumazet <eric.dumazet@gmail.com>
To: Pravin B Shelar <pshelar@nicira.com>
Cc: netdev@vger.kernel.org, edumazet@google.com, jesse@nicira.com,
stephen@networkplumber.org
Subject: Re: [PATCH net-next 3/4] tunneling: Add generic UDP-Tunnel TSO.
Date: Fri, 15 Feb 2013 17:34:40 -0800 [thread overview]
Message-ID: <1360978480.19353.36.camel@edumazet-glaptop> (raw)
In-Reply-To: <1360976774-1891-1-git-send-email-pshelar@nicira.com>
On Fri, 2013-02-15 at 17:06 -0800, Pravin B Shelar wrote:
> + /* segment inner packet. */
> + segs = skb_mac_gso_segment(skb, skb->dev->hw_enc_features);
> + if (!segs || IS_ERR(segs))
> + goto out;
> +
It seems that hw_enc_features is 0 for all devices.
We should at least inherit NETIF_F_SG
(and presumably netdev_fix_features() should not remove NETIF_F_SG if
CSUM is not supported, as we now copy the data _if_ needed in
skb_checksum_help())
next prev parent reply other threads:[~2013-02-16 1:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 1:06 [PATCH net-next 3/4] tunneling: Add generic UDP-Tunnel TSO Pravin B Shelar
2013-02-16 1:34 ` Eric Dumazet [this message]
2013-02-16 1:39 ` Pravin Shelar
2013-02-16 11:02 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360978480.19353.36.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=edumazet@google.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox