From: Cong Wang <amwang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, jiri@resnulli.us, vyasevic@redhat.com,
stephen@networkplumber.org
Subject: Re: [Patch net-next v2] netpoll: add some missing __rcu marks in several places
Date: Sat, 16 Feb 2013 11:16:27 +0800 [thread overview]
Message-ID: <1360984587.12539.2.camel@cr0> (raw)
In-Reply-To: <20130214.132054.2237485951582283881.davem@davemloft.net>
On Thu, 2013-02-14 at 13:20 -0500, David Miller wrote:
> From: Cong Wang <amwang@redhat.com>
> Date: Thu, 14 Feb 2013 16:37:19 +0800
>
> > From: Cong Wang <amwang@redhat.com>
> >
> > This fixes sparse warnings like the one below:
> >
> > drivers/net/team/team.c:953:25: warning: incorrect type in return expression (different address spaces)
> > drivers/net/team/team.c:953:25: expected struct netpoll_info *
> > drivers/net/team/team.c:953:25: got struct netpoll_info [noderef] <asn:4>*npinfo
> >
> > Cc: Jiri Pirko <jiri@resnulli.us>
> > Cc: Vlad Yasevich <vyasevic@redhat.com>
> > Cc: Stephen Hemminger <stephen@networkplumber.org>
> > Cc: David S. Miller <davem@davemloft.net>
> > Signed-off-by: Cong Wang <amwang@redhat.com>
>
> This is a very confusing patch submission.
>
> You're posting a "v2" of a patch but with a completely different Subject
> line so that it's hard, without looking into the details of the patch,
> to determine what this patch is a "v2" of.
>
> You've also not addressed Stephen's feedback about the lack of an
> rcu_dereference() in these routines you've added __rcu annotations
> to.
>
> I'm tossing all versions of this patch, therefore.
The reason is we don't dereference ->npinfo pointer, we just check if it
is NULL, so doesn't need to call rcu_dereference(). Or am I missing
anything?
Thanks.
next prev parent reply other threads:[~2013-02-16 3:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 6:12 [Patch net-next] bridge: add some missing __rcu marks Cong Wang
2013-02-14 6:39 ` Stephen Hemminger
2013-02-14 8:23 ` Cong Wang
2013-02-14 8:37 ` [Patch net-next v2] netpoll: add some missing __rcu marks in several places Cong Wang
2013-02-14 18:20 ` David Miller
2013-02-16 3:16 ` Cong Wang [this message]
2013-02-16 4:10 ` Eric Dumazet
2013-02-16 5:33 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360984587.12539.2.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).