From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, jiri@resnulli.us, vyasevic@redhat.com,
stephen@networkplumber.org
Subject: Re: [Patch net-next v2] netpoll: add some missing __rcu marks in several places
Date: Sat, 16 Feb 2013 13:33:34 +0800 [thread overview]
Message-ID: <1360992814.21612.0.camel@cr0> (raw)
In-Reply-To: <1360987823.19353.42.camel@edumazet-glaptop>
On Fri, 2013-02-15 at 20:10 -0800, Eric Dumazet wrote:
> On Sat, 2013-02-16 at 11:16 +0800, Cong Wang wrote:
>
> > The reason is we don't dereference ->npinfo pointer, we just check if it
> > is NULL, so doesn't need to call rcu_dereference(). Or am I missing
> > anything?
>
> Yes you are missing that the right thing to do is to use
> rcu_access_pointer()
>
> Sparse errors should not be fixed using random RCU verbs,
> please be more careful.
Ah, I wasn't aware of that API. Will send v3.
Thanks!
prev parent reply other threads:[~2013-02-16 5:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 6:12 [Patch net-next] bridge: add some missing __rcu marks Cong Wang
2013-02-14 6:39 ` Stephen Hemminger
2013-02-14 8:23 ` Cong Wang
2013-02-14 8:37 ` [Patch net-next v2] netpoll: add some missing __rcu marks in several places Cong Wang
2013-02-14 18:20 ` David Miller
2013-02-16 3:16 ` Cong Wang
2013-02-16 4:10 ` Eric Dumazet
2013-02-16 5:33 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360992814.21612.0.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).