From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>,
Vlad Yasevich <vyasevic@redhat.com>,
Stephen Hemminger <stephen@networkplumber.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next v3] net: fix some RCU warnings in various places
Date: Fri, 15 Feb 2013 22:23:24 -0800 [thread overview]
Message-ID: <1360995804.19353.55.camel@edumazet-glaptop> (raw)
In-Reply-To: <1360993680-7992-1-git-send-email-amwang@redhat.com>
On Sat, 2013-02-16 at 13:48 +0800, Cong Wang wrote:
> From: Cong Wang <amwang@redhat.com>
>
> This fixes sparse warnings like the one below:
> static inline void br_netpoll_send_skb(const struct net_bridge_port *p,
> @@ -469,7 +469,7 @@ extern void br_multicast_free_pg(struct rcu_head *head);
> extern struct net_bridge_port_group *br_multicast_new_port_group(
> struct net_bridge_port *port,
> struct br_ip *group,
> - struct net_bridge_port_group *next,
> + struct net_bridge_port_group __rcu *next,
> unsigned char state);
> extern void br_mdb_init(void);
> extern void br_mdb_uninit(void);
This part is wrong, please remove the __rcu annotation in function
definition.
To perform " rcu_assign_pointer(p->next, next); ", there is no need to
annotate "next" with __rcu
next prev parent reply other threads:[~2013-02-16 6:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 5:48 [Patch net-next v3] net: fix some RCU warnings in various places Cong Wang
2013-02-16 6:23 ` Eric Dumazet [this message]
2013-02-16 8:36 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360995804.19353.55.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox