netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Koki Sanagi <sanagi.koki@jp.fujitsu.com>,
	netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 02/15] e1000e: display a warning message when SmartSpeed works
Date: Sat, 16 Feb 2013 00:33:23 -0800	[thread overview]
Message-ID: <1361003616-3422-3-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1361003616-3422-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Koki Sanagi <sanagi.koki@jp.fujitsu.com>

Current e1000e driver doesn't tell nothing when Link Speed is downgraded due to
SmartSpeed.  As a result, users suspect that there is something wrong with
NIC.  If the cause of it is SmartSpeed, there is no means to replace NIC. This
patch make e1000e notify users that SmartSpeed worked.

Signed-off-by: Koki Sanagi <sanagi.koki@jp.fujitsu.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/e1000e/netdev.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 3f7dbd1..a177b8b 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -4830,6 +4830,13 @@ static void e1000_watchdog_task(struct work_struct *work)
 						   &adapter->link_speed,
 						   &adapter->link_duplex);
 			e1000_print_link_info(adapter);
+
+			/* check if SmartSpeed worked */
+			e1000e_check_downshift(hw);
+			if (phy->speed_downgraded)
+				netdev_warn(netdev,
+					    "Link Speed was downgraded by SmartSpeed\n");
+
 			/* On supported PHYs, check for duplex mismatch only
 			 * if link has autonegotiated at 10/100 half
 			 */
-- 
1.7.11.7

  parent reply	other threads:[~2013-02-16  8:33 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-16  8:33 [net-next 00/15][pull request] Intel Wired LAN Driver Updates 2013.02.16 Jeff Kirsher
2013-02-16  8:33 ` [net-next 01/15] e1000: fix whitespace issues and multi-line comments Jeff Kirsher
2013-02-16  8:33 ` Jeff Kirsher [this message]
2013-02-16  8:33 ` [net-next 03/15] igbvf: Make next_to_watch a pointer and adjust memory barriers to avoid races Jeff Kirsher
2013-02-16  8:33 ` [net-next 04/15] igb: increase timeout for ethtool offline self-test Jeff Kirsher
2013-02-16  8:33 ` [net-next 05/15] ixgbe: Define FCoE and Flow director limits much sooner to allow for changes Jeff Kirsher
2013-02-16  8:33 ` [net-next 06/15] ixgbe: Add function for setting XPS queue mapping Jeff Kirsher
2013-02-16  8:33 ` [net-next 07/15] ixgbe: Update ixgbe driver to use __netdev_pick_tx in ixgbe_select_queue Jeff Kirsher
2013-02-16  8:33 ` [net-next 08/15] ixgbe: Make ixgbe_setup_tc usable even when DCB is not enabled Jeff Kirsher
2013-02-16  8:33 ` [net-next 09/15] ixgbe: Add support for displaying the number of Tx/Rx channels Jeff Kirsher
2013-02-16  8:33 ` [net-next 10/15] ixgbe: Add support for set_channels ethtool operation Jeff Kirsher
2013-02-16  8:33 ` [net-next 11/15] ixgbe: fix possible data corruption in read_i2c_byte Jeff Kirsher
2013-02-16  8:33 ` [net-next 12/15] ixgbe: cleanup error checking in ixgbe_identify_sfp_module_generic() Jeff Kirsher
2013-02-16  8:33 ` [net-next 13/15] ixgbe: implement SFF diagnostic monitoring via ethtool Jeff Kirsher
2013-02-16 10:53   ` Michał Mirosław
2013-02-17  6:16     ` Tantilov, Emil S
2013-02-17 13:41       ` Michał Mirosław
2013-02-19 22:14   ` Ben Hutchings
2013-02-20  0:26     ` Tantilov, Emil S
2013-02-16  8:33 ` [net-next 14/15] ixgbe: fix Tx timeouts with BQL Jeff Kirsher
2013-02-16  8:33 ` [net-next 15/15] ixgbe: Update DESC_NEEDED define to adjust for changes to MAX_SKB_FRAGS Jeff Kirsher
2013-02-18 17:37 ` [net-next 00/15][pull request] Intel Wired LAN Driver Updates 2013.02.16 David Miller
2013-02-19 18:06   ` Tantilov, Emil S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1361003616-3422-3-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sanagi.koki@jp.fujitsu.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).