From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
jhs@mojatatu.com, kuznet@ms2.inr.ac.ru, j.vimal@gmail.com
Subject: Re: [patch net-next v5 10/11] tbf: take into account gso skbs
Date: Tue, 19 Feb 2013 08:15:02 -0800 [thread overview]
Message-ID: <1361290502.19353.136.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130218095837.GA1566@minipsycho.orion>
On Mon, 2013-02-18 at 10:58 +0100, Jiri Pirko wrote:
> Sun, Feb 17, 2013 at 06:54:23PM CET, eric.dumazet@gmail.com wrote:
> >On Sun, 2013-02-17 at 17:18 +0100, Jiri Pirko wrote:
> >
> >> I'm going through this issue back and front and on the second thought,
> >> I think this patch might not be so wrong after all.
> >>
> >> "Accumulating" time in ptoks would effectively cause the skb to be sent
> >> only in case time for whole skb is available (accumulated).
> >>
> >> The re-segmenting will only cause the skb fragments sent in each time frame.
> >>
> >> I can't see how the bigger bursts you are reffering to can happen.
> >>
> >> Or am I missing something?
> >
> >Token Bucket Filter doesnt allow to accumulate tokens above a given
> >threshold. Thats the whole point of the algo.
> >
> >After a one hour idle time, you don't want to allow your device sending
> >a burst exceeding the constraint.
>
> You are right, therefore I said "not so wrong". Let me illustrate my
> thoughts. Here is a patch:
>
> Subject: [patch net-next RFC] tbf: take into account gso skbs
>
> Ignore max_size check for gso skbs. This check made bigger packets
> incorrectly dropped. Remove this limitation for gso skbs.
>
> Also for peaks, accumulate time for big gso skbs.
>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
> ---
I am sorry, we can not do this accumulation.
If we are allowed to send 1k per second, we are not allowed to send 10k
after 10 seconds of idle.
Either we are able to split the GSO packet, and respect the TBF
constraints, either we must drop it.
next prev parent reply other threads:[~2013-02-19 16:15 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 10:11 [patch net-next v5 00/11] couple of net/sched fixes+improvements Jiri Pirko
2013-02-12 10:11 ` [patch net-next v5 01/11] htb: use PSCHED_TICKS2NS() Jiri Pirko
2013-02-13 0:00 ` David Miller
2013-02-12 10:12 ` [patch net-next v5 02/11] htb: fix values in opt dump Jiri Pirko
2013-02-12 23:51 ` David Miller
2013-02-12 10:12 ` [patch net-next v5 03/11] htb: remove pointless first initialization of buffer and cbuffer Jiri Pirko
2013-02-13 0:00 ` David Miller
2013-02-12 10:12 ` [patch net-next v5 04/11] htb: initialize cl->tokens and cl->ctokens correctly Jiri Pirko
2013-02-13 0:00 ` David Miller
2013-02-12 10:12 ` [patch net-next v5 05/11] sch: make htb_rate_cfg and functions around that generic Jiri Pirko
2013-02-13 0:00 ` David Miller
2013-02-12 10:12 ` [patch net-next v5 06/11] sch_api: introduce qdisc_watchdog_schedule_ns() Jiri Pirko
2013-02-12 16:32 ` Eric Dumazet
2013-02-13 0:00 ` David Miller
2013-02-12 10:12 ` [patch net-next v5 07/11] tbf: improved accuracy at high rates Jiri Pirko
2013-02-12 16:34 ` Eric Dumazet
2013-02-13 0:01 ` David Miller
2013-02-12 10:12 ` [patch net-next v5 08/11] act_police: move struct tcf_police to act_police.c Jiri Pirko
2013-02-12 12:08 ` Jamal Hadi Salim
2013-02-12 16:34 ` Eric Dumazet
2013-02-13 0:01 ` David Miller
2013-02-12 10:12 ` [patch net-next v5 09/11] act_police: improved accuracy at high rates Jiri Pirko
2013-02-12 13:31 ` Jamal Hadi Salim
2013-02-12 13:39 ` Jiri Pirko
2013-02-13 0:01 ` David Miller
2013-02-12 10:12 ` [patch net-next v5 10/11] tbf: take into account gso skbs Jiri Pirko
2013-02-12 16:39 ` Eric Dumazet
2013-02-12 17:31 ` Jiri Pirko
2013-02-12 17:54 ` Eric Dumazet
2013-02-17 16:18 ` Jiri Pirko
2013-02-17 17:54 ` Eric Dumazet
2013-02-18 9:58 ` Jiri Pirko
2013-02-19 16:15 ` Eric Dumazet [this message]
2013-02-19 16:46 ` Jiri Pirko
2013-02-19 17:01 ` Eric Dumazet
2013-03-08 15:23 ` Jiri Pirko
2013-03-22 10:02 ` Jiri Pirko
2013-02-12 10:12 ` [patch net-next v5 11/11] act_police: remove <=mtu check for " Jiri Pirko
2013-02-12 16:40 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361290502.19353.136.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vimal@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox