From: Eric Dumazet <eric.dumazet@gmail.com>
To: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: "Allan, Bruce W" <bruce.w.allan@intel.com>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
Daniel Santos <daniel.santos@pobox.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Wu, Fengguang" <fengguang.wu@intel.com>
Subject: Re: [E1000-devel] [next:akpm 16/587] drivers/net/ethernet/intel/igb/igb_main.c:6231:2: error: call to '__compiletime_assert_6235' declared with attribute error: BUILD_BUG_ON failed: SKB_WITH_OVERHEAD(IGB_RX_BUFSZ) < (NET_SKB_PAD + NET_IP_ALIGN + IGB_TS_HDR_LEN + ETH...
Date: Wed, 20 Feb 2013 11:22:36 -0800 [thread overview]
Message-ID: <1361388156.19353.216.camel@edumazet-glaptop> (raw)
In-Reply-To: <51251303.9030803@intel.com>
On Wed, 2013-02-20 at 10:16 -0800, Alexander Duyck wrote:
>
> The problem is the 256 byte alignment for L1_CACHE_BYTES is increasing
> the size of the data and shared info significantly pushing us past the
> 2K limit.
>
> I'll look into this since it likely affects ixgbe as well.
Thats what I said.
Using 256 bytes of headroom is silly.
We should limit NET_SKB_PAD to the 32-64 range
next prev parent reply other threads:[~2013-02-20 19:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5122101a.nBjTqFyZXZ+WuzPr%fengguang.wu@intel.com>
2013-02-19 22:27 ` [next:akpm 16/587] drivers/net/ethernet/intel/igb/igb_main.c:6231:2: error: call to '__compiletime_assert_6235' declared with attribute error: BUILD_BUG_ON failed: SKB_WITH_OVERHEAD(IGB_RX_BUFSZ) < (NET_SKB_PAD + NET_IP_ALIGN + IGB_TS_HDR_LEN + ETH_FRAME_LEN + ETH_FCS_LEN) Andrew Morton
2013-02-19 22:30 ` [next:akpm 16/587] drivers/net/ethernet/intel/igb/igb_main.c:6231:2: error: call to '__compiletime_assert_6235' declared with attribute error: BUILD_BUG_ON failed: SKB_WITH_OVERHEAD(IGB_RX_BUFSZ) < (NET_SKB_PAD + NET_IP_ALIGN + IGB_TS_HDR_LEN + ETH Allan, Bruce W
2013-02-20 1:09 ` Eric Dumazet
2013-02-20 18:16 ` [E1000-devel] " Alexander Duyck
2013-02-20 19:22 ` Eric Dumazet [this message]
2013-02-20 21:23 ` Alexander Duyck
2013-02-20 21:42 ` Eric Dumazet
2013-02-20 22:47 ` Alexander Duyck
2013-02-20 23:02 ` Eric Dumazet
2013-02-21 9:42 ` [E1000-devel] [next:akpm 16/587] drivers/net/ethernet/intel/igb/igb_main.c:6231:2: error: call to '__compiletime_assert_6235' declared with attribute error: BUILD_BUG_ON failed: SKB_WITH_OVERHEAD(IGB_RX_BUFSZ) < (NET_SKB_PAD + NET_IP_ALIGN + IGB_TS_HD David Laight
2013-02-19 23:02 ` [next:akpm 16/587] drivers/net/ethernet/intel/igb/igb_main.c:6231:2: error: call to '__compiletime_assert_6235' declared with attribute error: BUILD_BUG_ON failed: SKB_WITH_OVERHEAD(IGB_RX_BUFSZ) < (NET_SKB_PAD + NET_IP_ALIGN + IGB_TS_HDR_LEN + ETH Wyborny, Carolyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361388156.19353.216.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@intel.com \
--cc=bruce.w.allan@intel.com \
--cc=daniel.santos@pobox.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=fengguang.wu@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox