From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: bind@enas.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Kernel 3.7.2 strange warning and short system hang
Date: Wed, 20 Feb 2013 11:30:19 -0800 [thread overview]
Message-ID: <1361388619.19353.221.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130220.125715.2150428275032134361.davem@davemloft.net>
On Wed, 2013-02-20 at 12:57 -0500, David Miller wrote:
> I've seen this pattern on several occasions and I have to wonder...
>
> Do we really require, therefore, every NAPI driver to use dev_kfree_skb_any()
> in it's TX reclaim if it supports netpoll?
>
> That seems completely bogus.
>
> netpoll is supposed to provide an execution environment when it invokes
> ->poll() that is identical to the normal NAPI execution. If that would
> be true, then this change above would be completely unnecessary.
>
> We need to figure out what is the case here, and audit all the NAPI
> drivers to make sure they do the right thing once we know what the
> right thing actually is.
netpoll directly calls n->poll()
(poll_napi() -> poll_one_napi() -> napi->poll(napi, budget) )
Presumably it should not do that if running in interrupt context.
next prev parent reply other threads:[~2013-02-20 19:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5124F57A.6080908@enas.net>
2013-02-20 16:52 ` Kernel 3.7.2 strange warning and short system hang Eric Dumazet
2013-02-20 17:57 ` David Miller
2013-02-20 19:30 ` Eric Dumazet [this message]
2013-02-22 9:49 ` Urban Loesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361388619.19353.221.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=bind@enas.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox