From: Eric Dumazet <eric.dumazet@gmail.com>
To: Pravin Shelar <pshelar@nicira.com>
Cc: netdev@vger.kernel.org, edumazet@google.com, jesse@nicira.com
Subject: Re: [PATCH net-next] IP_GRE: Fix IP-Identification.
Date: Thu, 21 Feb 2013 22:06:25 -0800 [thread overview]
Message-ID: <1361513185.3683.1.camel@edumazet-glaptop> (raw)
In-Reply-To: <CALnjE+qOTnzdEjuGheRBhVC9piHdVKornV4Fv=ZubKS6ZAF6gQ@mail.gmail.com>
On Thu, 2013-02-21 at 19:42 -0800, Pravin Shelar wrote:
> Without this patch GRE-GSO generates ip fragments with id 0,2,3,4...
> for every GSO packet, which is not correct. This patch fixes it.
> --
I guess my question was more : Why dont we inherit ID from the inner
packet ?
ip_select_ident_more() is a performance killer, as all cpus are going to
access a shared counter in the dst.
next prev parent reply other threads:[~2013-02-22 6:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 2:18 [PATCH net-next] IP_GRE: Fix IP-Identification Pravin B Shelar
2013-02-22 2:35 ` Eric Dumazet
2013-02-22 3:42 ` Pravin Shelar
2013-02-22 6:06 ` Eric Dumazet [this message]
2013-02-22 7:17 ` pravin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361513185.3683.1.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=edumazet@google.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox