From: Cong Wang <amwang@redhat.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>, Jesse Gross <jesse@nicira.com>
Subject: Re: [Patch] openvswitch: fix the calculation of checksum for vlan header
Date: Fri, 22 Feb 2013 17:29:52 +0800 [thread overview]
Message-ID: <1361525392.1614.14.camel@cr0> (raw)
In-Reply-To: <1361510722-27831-1-git-send-email-amwang@redhat.com>
On Fri, 2013-02-22 at 13:25 +0800, Cong Wang wrote:
> @@ -115,7 +115,7 @@ static int push_vlan(struct sk_buff *skb, const struct ovs_action_push_vlan *vla
>
> if (skb->ip_summed == CHECKSUM_COMPLETE)
> skb->csum = csum_add(skb->csum, csum_partial(skb->data
> - + ETH_HLEN, VLAN_HLEN, 0));
> + + (2 * ETH_ALEN), VLAN_HLEN, 0));
>
> }
> __vlan_hwaccel_put_tag(skb, ntohs(vlan->vlan_tci) & ~VLAN_TAG_PRESENT);
__pop_vlan_tci() has same problem...
I will resend this patch.
prev parent reply other threads:[~2013-02-22 10:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 5:25 [Patch] openvswitch: fix the calculation of checksum for vlan header Cong Wang
2013-02-22 9:29 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361525392.1614.14.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).