From: Eric Dumazet <eric.dumazet@gmail.com>
To: Javier Domingo <javierdo1@gmail.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: Softirqs without captured packets
Date: Fri, 22 Feb 2013 06:11:21 -0800 [thread overview]
Message-ID: <1361542281.3683.3.camel@edumazet-glaptop> (raw)
In-Reply-To: <CALZVapmKbqcamTYTEhoerRUPpjsaLJqoTo84Fqmz+aUWWTmh2g@mail.gmail.com>
On Fri, 2013-02-22 at 10:32 +0100, Javier Domingo wrote:
> Which is the reason for that in the poll function, not only some
> drivers have that tx completion (I suppose it is to free resources),
> but also to send packets in that routine?
>
> In e1000e, I have found that it frees resources used in tx, with the
> e1000_clean_tx_irq, and also, although the tx completion is first, it
> executes the rx routine.
>
> On the other hand, tg3 driver not only does the tx resources free but
> also sends packets in that time, and may return from the poll thought
> it might not have done rx work in the net_rx_action routine.
>
> Why is this like that? I mean, why all the tx is done *before* the rx
> thread, thought it may not do any rx work (in tg3) ?
To free memory, so that rx handler gets more chance to be able to
allocate memory, and reuse memory already hot in cpu caches.
next prev parent reply other threads:[~2013-02-22 14:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 19:41 Softirqs without captured packets Javier Domingo
2013-02-08 19:54 ` Javier Domingo
2013-02-08 19:57 ` David Miller
2013-02-08 20:02 ` Javier Domingo
2013-02-08 20:15 ` David Miller
2013-02-08 21:22 ` Javier Domingo
2013-02-09 20:27 ` Javier Domingo
2013-02-10 1:16 ` Eric Dumazet
2013-02-10 3:02 ` Javier Domingo
2013-02-10 8:16 ` Eric Dumazet
[not found] ` <CALZVapm1evE6rOgNkJapu9VboA6OojKGJ-UhRhZ26J0A+k4nmw@mail.gmail.com>
2013-02-22 9:32 ` Javier Domingo
2013-02-22 14:11 ` Eric Dumazet [this message]
2013-03-06 17:20 ` Javier Domingo
2013-03-06 19:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361542281.3683.3.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=javierdo1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox