From: "Eilon Greenstein" <eilong@broadcom.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>
Cc: "David Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, dmitry@broadcom.com, yanivr@broadcom.com
Subject: Re: [PATCH net] bnx2x: remove dead code and make local funcs static
Date: Sun, 24 Feb 2013 22:25:20 +0200 [thread overview]
Message-ID: <1361737520.3557.3.camel@lb-tlvb-eilong.il.broadcom.com> (raw)
In-Reply-To: <20130222100110.057520e1@nehalam.linuxnetplumber.net>
On Fri, 2013-02-22 at 10:01 -0800, Stephen Hemminger wrote:
> Sparse warned about several functions that were unnecessarily global.
> After making them static, discovered that several functions were actually never used.
>
> Compile tested only.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
Hi Stephen,
Thanks for this patch. The "dead code" part is actually a missing call
in case of PHY FW upgrade for the 84833 PHY - without it, a server
reboot is required for the new PHY FW to take affect - but this reboot
saving enhancement should wait until net-next is open, so I'm acking
this patch and we will add the code back with the proper call once the
net-next is open again.
Acked-by: Eilon Greenstein <eilong@broadcomo.com>
next prev parent reply other threads:[~2013-02-24 20:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 18:01 [PATCH net] bnx2x: remove dead code and make local funcs static Stephen Hemminger
2013-02-24 20:25 ` Eilon Greenstein [this message]
2013-02-25 1:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361737520.3557.3.camel@lb-tlvb-eilong.il.broadcom.com \
--to=eilong@broadcom.com \
--cc=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=yanivr@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox