From: Joe Perches <joe@perches.com>
To: Syam Sidhardhan <syamsidhardh@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net/pasemi: Fix missing coding style
Date: Sun, 24 Feb 2013 15:29:38 -0800 [thread overview]
Message-ID: <1361748578.2281.6.camel@joe-AO722> (raw)
In-Reply-To: <1361748185.2281.2.camel@joe-AO722>
On Sun, 2013-02-24 at 15:23 -0800, Joe Perches wrote:
> On Mon, 2013-02-25 at 04:31 +0530, Syam Sidhardhan wrote:
> > Fix missing () & { }
> []
> > diff --git a/drivers/net/ethernet/pasemi/pasemi_mac.c b/drivers/net/ethernet/pasemi/pasemi_mac.c
> []
> > @@ -1829,10 +1831,11 @@ pasemi_mac_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> > dev_err(&mac->pdev->dev, "register_netdev failed with error %d\n",
> > err);
> > goto out;
> > - } else if netif_msg_probe(mac)
> > + } else if (netif_msg_probe(mac)) {
> > printk(KERN_INFO "%s: PA Semi %s: intf %d, hw addr %pM\n",
> > dev->name, mac->type == MAC_TYPE_GMAC ? "GMAC" : "XAUI",
> > mac->dma_if, dev->dev_addr);
> > + }
> >
> > return err;
> >
>
> Uncompilable since 2007!
> That argues more for removal than anything else.
Nevermind. Not true.
netif_msg_probe is already surrounded by parens.
It's just stylistic ugly.
next prev parent reply other threads:[~2013-02-24 23:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-24 23:01 [PATCH] net/pasemi: Fix missing coding style Syam Sidhardhan
2013-02-24 23:23 ` Joe Perches
2013-02-24 23:29 ` Joe Perches [this message]
2013-02-25 0:53 ` Olof Johansson
2013-02-25 0:51 ` Olof Johansson
2013-02-25 1:13 ` David Miller
2013-02-25 1:23 ` Joe Perches
2013-02-25 1:52 ` David Miller
2013-02-25 2:11 ` Joe Perches
2013-02-25 2:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361748578.2281.6.camel@joe-AO722 \
--to=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=syamsidhardh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).