From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: syamsidhardh@gmail.com, netdev@vger.kernel.org, olof@lixom.net
Subject: Re: [PATCH] net/pasemi: Fix missing coding style
Date: Sun, 24 Feb 2013 17:23:29 -0800 [thread overview]
Message-ID: <1361755409.2281.9.camel@joe-AO722> (raw)
In-Reply-To: <20130224.201301.457851300548359313.davem@davemloft.net>
On Sun, 2013-02-24 at 20:13 -0500, David Miller wrote:
> From: Syam Sidhardhan <syamsidhardh@gmail.com>
> Date: Mon, 25 Feb 2013 04:31:19 +0530
>
> > - } else
> > + } else {
> > freed = 2;
> > + }
>
> Single line statements do not need braces.
I guess you didn't see the preceding block with braces.
CodingStyle:
This does not apply if only one branch of a conditional statement is a single
statement; in the latter case use braces in both branches:
next prev parent reply other threads:[~2013-02-25 1:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-24 23:01 [PATCH] net/pasemi: Fix missing coding style Syam Sidhardhan
2013-02-24 23:23 ` Joe Perches
2013-02-24 23:29 ` Joe Perches
2013-02-25 0:53 ` Olof Johansson
2013-02-25 0:51 ` Olof Johansson
2013-02-25 1:13 ` David Miller
2013-02-25 1:23 ` Joe Perches [this message]
2013-02-25 1:52 ` David Miller
2013-02-25 2:11 ` Joe Perches
2013-02-25 2:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361755409.2281.9.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=olof@lixom.net \
--cc=syamsidhardh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).