From: Eric Dumazet <eric.dumazet@gmail.com>
To: David L Stevens <dlstevens@us.ibm.com>
Cc: David Miller <davem@davemloft.net>,
Stephen Hemminger <shemminger@vyatta.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] generalize VXLAN forwarding tables
Date: Thu, 28 Feb 2013 14:27:55 -0800 [thread overview]
Message-ID: <1362090475.15793.51.camel@edumazet-glaptop> (raw)
In-Reply-To: <201302281924.r1SJN7u5024149@lab1.dls>
On Thu, 2013-02-28 at 14:23 -0500, David L Stevens wrote:
> + /* if there are multiple destinations, send copies */
> + for (rdst = rdst0->remote_next; rdst; rdst = rdst->remote_next) {
> + struct sk_buff *skb1;
> +
> + skb1 = skb_clone(skb, GFP_ATOMIC);
> + rc1 = vxlan_xmit_one(skb1, dev, rdst, did_rsc);
> + if (rc == NETDEV_TX_OK)
> + rc = rc1;
> + }
> +
> + rc1 = vxlan_xmit_one(skb, dev, rdst0, did_rsc);
> + if (rc == NETDEV_TX_OK)
> + rc = rc1;
> + return rc;
> +}
It looks like vxlan_xmit_one() will overwrite header
So skb_clone() is probably not what you wanted ?
next prev parent reply other threads:[~2013-02-28 22:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 19:23 [PATCH net-next] generalize VXLAN forwarding tables David L Stevens
2013-02-28 22:27 ` Eric Dumazet [this message]
2013-02-28 22:55 ` David Stevens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362090475.15793.51.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox