* [PATCH] filter: fix sparse warning for bpf_internal_load_pointer_neg_helper
@ 2013-03-03 23:30 Claudiu Ghioc
2013-03-04 2:08 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: Claudiu Ghioc @ 2013-03-03 23:30 UTC (permalink / raw)
To: davem; +Cc: edumazet, dborkman, jpirko, akpm, netdev, linux-kernel,
Claudiu Ghioc
Removed the following sparse warning:
* net/core/filter.c:48:6: warning: symbol
'bpf_internal_load_pointer_neg_helper' was
not declared. Should it be static?
Signed-off-by: Claudiu Ghioc <claudiu.ghioc@gmail.com>
---
net/core/filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/filter.c b/net/core/filter.c
index 2e20b55..f6c907c 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -45,7 +45,7 @@
*
* Exported for the bpf jit load helper.
*/
-void *bpf_internal_load_pointer_neg_helper(const struct sk_buff *skb, int k, unsigned int size)
+static void *bpf_internal_load_pointer_neg_helper(const struct sk_buff *skb, int k, unsigned int size)
{
u8 *ptr = NULL;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] filter: fix sparse warning for bpf_internal_load_pointer_neg_helper
2013-03-03 23:30 [PATCH] filter: fix sparse warning for bpf_internal_load_pointer_neg_helper Claudiu Ghioc
@ 2013-03-04 2:08 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2013-03-04 2:08 UTC (permalink / raw)
To: Claudiu Ghioc
Cc: davem, edumazet, dborkman, jpirko, akpm, netdev, linux-kernel,
Claudiu Ghioc
On Mon, 2013-03-04 at 01:30 +0200, Claudiu Ghioc wrote:
> Removed the following sparse warning:
> * net/core/filter.c:48:6: warning: symbol
> 'bpf_internal_load_pointer_neg_helper' was
> not declared. Should it be static?
>
> Signed-off-by: Claudiu Ghioc <claudiu.ghioc@gmail.com>
> ---
> net/core/filter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 2e20b55..f6c907c 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -45,7 +45,7 @@
> *
> * Exported for the bpf jit load helper.
> */
> -void *bpf_internal_load_pointer_neg_helper(const struct sk_buff *skb, int k, unsigned int size)
> +static void *bpf_internal_load_pointer_neg_helper(const struct sk_buff *skb, int k, unsigned int size)
> {
> u8 *ptr = NULL;
>
Hmm, have you read the comment ?
Also :
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-04 2:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-03 23:30 [PATCH] filter: fix sparse warning for bpf_internal_load_pointer_neg_helper Claudiu Ghioc
2013-03-04 2:08 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox