From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, bugs@syam.in,
David Ward <david.ward@ll.mit.edu>,
Stephen Hemminger <stephen@networkplumber.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net] garp: fix a NULL pointer dereference bug
Date: Mon, 04 Mar 2013 06:56:15 -0800 [thread overview]
Message-ID: <1362408975.15793.92.camel@edumazet-glaptop> (raw)
In-Reply-To: <1362390955.2383.2.camel@cr0>
On Mon, 2013-03-04 at 17:55 +0800, Cong Wang wrote:
> On Sun, 2013-03-03 at 21:26 -0800, Eric Dumazet wrote:
> >
> > Nope this patch doesnt solve the problem
> >
> > Crash is in :
> >
> > 49 8b 1c c6 mov (%r14,%rax,8),%rbx
> >
> > Thats because r14 (port) is NULL
> >
> >
> >
>
> Hmm, but I can't see how it can be NULL, the only place of NULL'ing it
> is inside garp_release_port(), right after the piece of code that I
> patched.
>
> Thanks!
>
Maybe port is NULL from the beginning.
Try to inject memory allocations error in garp_init_port()
prev parent reply other threads:[~2013-03-04 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 3:36 [Patch net] garp: fix a NULL pointer dereference bug Cong Wang
2013-03-04 3:41 ` Cong Wang
2013-03-04 5:26 ` Eric Dumazet
2013-03-04 9:55 ` Cong Wang
2013-03-04 14:56 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362408975.15793.92.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=amwang@redhat.com \
--cc=bugs@syam.in \
--cc=davem@davemloft.net \
--cc=david.ward@ll.mit.edu \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox