From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Alexander Aring <alex.aring@gmail.com>,
davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org,
linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6 addrconf: Fix addrconf_ifid_eui64 of 802.15.4 devices
Date: Thu, 07 Mar 2013 14:57:05 -0800 [thread overview]
Message-ID: <1362697025.15793.221.camel@edumazet-glaptop> (raw)
In-Reply-To: <1362696088.2936.47.camel@bwh-desktop.uk.solarflarecom.com>
On Thu, 2013-03-07 at 22:41 +0000, Ben Hutchings wrote:
> On Thu, 2013-03-07 at 21:13 +0100, Alexander Aring wrote:
> > The function addrconf_ifid_eui64 will copy eui into dev->dev_addr.
> > We need first to manipulate eui[0] before we call memcpy afterwards.
>
> memcpy() does not work that way.
>
> > Broken since commit:
> > 5e98a36ed4bf6ea396170e3af0dd4fcbe51d772f
> >
> > Since this commit I got many trouble with the ieee802154 stack.
>
> Your change is effectively reverting that commit.
Reverting the commit seems the solution ;)
next prev parent reply other threads:[~2013-03-07 22:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 20:13 [PATCH] ipv6 addrconf: Fix addrconf_ifid_eui64 of 802.15.4 devices Alexander Aring
2013-03-07 20:41 ` Alexander Aring
2013-03-08 2:21 ` YOSHIFUJI Hideaki
2013-03-08 9:37 ` Alexander Aring
2013-03-08 17:30 ` YOSHIFUJI Hideaki
2013-03-09 4:34 ` YOSHIFUJI Hideaki
2013-03-09 20:08 ` Alexander Aring
2013-03-07 22:41 ` Ben Hutchings
2013-03-07 22:57 ` Eric Dumazet [this message]
2013-03-07 23:17 ` David Miller
2013-03-08 8:53 ` Alexander Aring
[not found] ` <1362696088.2936.47.camel-/LGg1Z1CJKReKY3V0RtoKmatzQS1i7+A3tAM5lWOD0I@public.gmane.org>
2013-03-08 9:04 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362697025.15793.221.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=alex.aring@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).