From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH RFC] ipv6: use stronger hash for reassembly queue hash table
Date: Fri, 08 Mar 2013 06:53:06 -0800 [thread overview]
Message-ID: <1362754386.15793.226.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130308130433.GB28531@order.stressinduktion.org>
On Fri, 2013-03-08 at 14:04 +0100, Hannes Frederic Sowa wrote:
> Ok if I send a patch later to revert this change? What do you think about
> increasing the size of the fragmentation queue hash table INETFRAGS_HASHSZ,
> too?
Thats because reassembly hash was so small, and number of in flight
reassembly is so small anyway, that I felt not worth having so many
instructions to compute a hash that is truncated to 6 bits
In real life I always advocate _not_ using fragments, I dont know why so
many people try to used them.
No matter how you hash, a hacker can easily fill your defrag unit with
not complete datagrams, so what's the point ?
next prev parent reply other threads:[~2013-03-08 14:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 21:42 [PATCH RFC] ipv6: use stronger hash for reassembly queue hash table Hannes Frederic Sowa
2013-03-08 5:57 ` Hannes Frederic Sowa
2013-03-08 13:04 ` Hannes Frederic Sowa
2013-03-08 14:53 ` Eric Dumazet [this message]
2013-03-08 15:08 ` Hannes Frederic Sowa
2013-03-08 15:23 ` Eric Dumazet
2013-03-08 15:54 ` Hannes Frederic Sowa
2013-03-08 16:15 ` Eric Dumazet
2013-03-08 16:18 ` Hannes Frederic Sowa
2013-03-09 15:19 ` Hannes Frederic Sowa
2013-03-08 20:53 ` Hannes Frederic Sowa
2013-03-13 1:27 ` Hannes Frederic Sowa
2013-03-13 1:31 ` Hannes Frederic Sowa
2013-03-13 5:29 ` Eric Dumazet
2013-03-14 1:37 ` Hannes Frederic Sowa
2013-03-14 4:36 ` Stephen Hemminger
2013-03-14 7:14 ` Hannes Frederic Sowa
2013-03-14 9:47 ` David Laight
2013-03-14 10:34 ` Eric Dumazet
2013-03-14 12:34 ` Hannes Frederic Sowa
2013-03-14 7:10 ` Jesper Dangaard Brouer
2013-03-14 7:23 ` Hannes Frederic Sowa
2013-03-14 7:28 ` Hannes Frederic Sowa
2013-03-14 9:18 ` Jesper Dangaard Brouer
2013-03-14 12:45 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362754386.15793.226.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox