From: Eric Dumazet <eric.dumazet@gmail.com>
To: Bill Fink <billfink@mindspring.com>
Cc: Vimal <j.vimal@gmail.com>,
netdev@vger.kernel.org, shemminger <shemminger@vyatta.com>
Subject: Re: [PATCH] Rate should be u64 to avoid integer overflow at high speeds (>= ~35Gbit)
Date: Sun, 10 Mar 2013 06:54:36 +0100 [thread overview]
Message-ID: <1362894876.4051.27.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130310004904.de508bfa.billfink@mindspring.com>
On Sun, 2013-03-10 at 00:49 -0500, Bill Fink wrote:
> I don't see the problem. An old program would not know about
> the new multiplier, would thus get the default multiplier of 1,
> and get the same behavior as always, with the same limitation
> of ~34 Gbps. But someone with a newer tc/kernel could for example
> specify a multiplier of 10, which would then support rates up to
> about 340 Gbps. It sounds like a reasonable approach to me.
Hopefully, some of us see the problem here and are able to reject
patches before breaking user land.
next prev parent reply other threads:[~2013-03-10 5:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 3:20 [PATCH] Rate should be u64 to avoid integer overflow at high speeds (>= ~35Gbit) Vimalkumar
2013-03-10 4:03 ` Eric Dumazet
2013-03-10 4:53 ` Vimal
2013-03-10 5:05 ` Eric Dumazet
2013-03-10 5:49 ` Bill Fink
2013-03-10 5:54 ` Eric Dumazet [this message]
2013-03-12 14:29 ` Chris Friesen
2013-03-12 15:42 ` Thomas Graf
2013-03-12 15:44 ` Eric Dumazet
2013-03-12 15:53 ` Chris Friesen
2013-03-12 15:56 ` Chris Friesen
2013-03-13 6:01 ` Bill Fink
2013-03-13 6:13 ` Eric Dumazet
2013-03-13 15:29 ` Bill Fink
2013-03-13 15:34 ` Stephen Hemminger
2013-03-13 16:57 ` Chris Friesen
2013-03-14 4:08 ` Bill Fink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362894876.4051.27.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=billfink@mindspring.com \
--cc=j.vimal@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox