From: Hong Zhiguo <honkiko@gmail.com>
To: netdev@vger.kernel.org, davem@davemloft.net, stephen@networkplumber.org
Cc: zhiguo.hong@emc.com, Hong Zhiguo <honkiko@gmail.com>
Subject: [PATCH net-next] fix buf of assigning skb->tail to network_header
Date: Sun, 10 Mar 2013 17:48:29 +0800 [thread overview]
Message-ID: <1362908909-45697-1-git-send-email-honkiko@gmail.com> (raw)
in the case of NET_SKBUFF_DATA_USES_OFFSET, direct pointer
assignment to skb->network_header is a dangerous bug.
Signed-off-by: Hong Zhiguo <honkiko@gmail.com>
---
net/ipv4/ipmr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c
index 5f95b3a..553409b 100644
--- a/net/ipv4/ipmr.c
+++ b/net/ipv4/ipmr.c
@@ -980,7 +980,7 @@ static int ipmr_cache_report(struct mr_table *mrt,
/* Copy the IP header */
- skb->network_header = skb->tail;
+ skb_set_network_header(skb, skb->tail - skb->data);
skb_put(skb, ihl);
skb_copy_to_linear_data(skb, pkt->data, ihl);
ip_hdr(skb)->protocol = 0; /* Flag to the kernel this is a route add */
--
1.7.10.4
next reply other threads:[~2013-03-10 9:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 9:48 Hong Zhiguo [this message]
2013-03-10 9:58 ` [PATCH net-next] fix buf of assigning skb->tail to network_header Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362908909-45697-1-git-send-email-honkiko@gmail.com \
--to=honkiko@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=zhiguo.hong@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).