* [PATCH] wireless:rtlwifi: replaced kmalloc+memcpy with kmemdup
@ 2013-03-10 13:09 Andrei Epure
2013-03-11 20:46 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Andrei Epure @ 2013-03-10 13:09 UTC (permalink / raw)
To: Larry.Finger, chaoming_li, linville
Cc: linux-wireless, netdev, linux-kernel, Andrei Epure
Signed-off-by: Andrei Epure <epure.andrei@gmail.com>
---
drivers/net/wireless/rtlwifi/usb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/usb.c b/drivers/net/wireless/rtlwifi/usb.c
index 156b527..b5c80b5 100644
--- a/drivers/net/wireless/rtlwifi/usb.c
+++ b/drivers/net/wireless/rtlwifi/usb.c
@@ -224,10 +224,9 @@ static void _usb_writeN_sync(struct rtl_priv *rtlpriv, u32 addr, void *data,
u8 *buffer;
wvalue = (u16)(addr & 0x0000ffff);
- buffer = kmalloc(len, GFP_ATOMIC);
+ buffer = kmemdup(data, len, GFP_ATOMIC);
if (!buffer)
return;
- memcpy(buffer, data, len);
usb_control_msg(udev, pipe, request, reqtype, wvalue,
index, buffer, len, 50);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wireless:rtlwifi: replaced kmalloc+memcpy with kmemdup
2013-03-10 13:09 [PATCH] wireless:rtlwifi: replaced kmalloc+memcpy with kmemdup Andrei Epure
@ 2013-03-11 20:46 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2013-03-11 20:46 UTC (permalink / raw)
To: Andrei Epure; +Cc: chaoming_li, linville, linux-wireless, netdev, linux-kernel
On 03/10/2013 08:09 AM, Andrei Epure wrote:
> Signed-off-by: Andrei Epure <epure.andrei@gmail.com>
> ---
> drivers/net/wireless/rtlwifi/usb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/usb.c b/drivers/net/wireless/rtlwifi/usb.c
> index 156b527..b5c80b5 100644
> --- a/drivers/net/wireless/rtlwifi/usb.c
> +++ b/drivers/net/wireless/rtlwifi/usb.c
> @@ -224,10 +224,9 @@ static void _usb_writeN_sync(struct rtl_priv *rtlpriv, u32 addr, void *data,
> u8 *buffer;
>
> wvalue = (u16)(addr & 0x0000ffff);
> - buffer = kmalloc(len, GFP_ATOMIC);
> + buffer = kmemdup(data, len, GFP_ATOMIC);
> if (!buffer)
> return;
> - memcpy(buffer, data, len);
> usb_control_msg(udev, pipe, request, reqtype, wvalue,
> index, buffer, len, 50);
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks,
Larry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-11 20:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-10 13:09 [PATCH] wireless:rtlwifi: replaced kmalloc+memcpy with kmemdup Andrei Epure
2013-03-11 20:46 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).