* [PATCH] wireless:iwlwifi: changed kmalloc+memcpy with kmemdup
@ 2013-03-10 13:22 Andrei Epure
2013-03-10 15:10 ` Johannes Berg
2013-03-10 15:18 ` Johannes Berg
0 siblings, 2 replies; 3+ messages in thread
From: Andrei Epure @ 2013-03-10 13:22 UTC (permalink / raw)
To: johannes.berg-ral2JQCrhuEAvxtiuMwx3w,
wey-yi.w.guy-ral2JQCrhuEAvxtiuMwx3w, ilw-VuQAYsv1563Yd54FQh9/CA,
linville-2XuSBdqkA4R54TAoqtyWWQ
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Andrei Epure
Signed-off-by: Andrei Epure <epure.andrei-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/net/wireless/iwlwifi/iwl-test.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-test.c b/drivers/net/wireless/iwlwifi/iwl-test.c
index ce0c67b..9bc402c 100644
--- a/drivers/net/wireless/iwlwifi/iwl-test.c
+++ b/drivers/net/wireless/iwlwifi/iwl-test.c
@@ -271,7 +271,7 @@ static int iwl_test_fw_cmd(struct iwl_test *tst, struct nlattr **tb)
reply_len = le32_to_cpu(pkt->len_n_flags) & FH_RSCSR_FRAME_SIZE_MSK;
skb = iwl_test_alloc_reply(tst, reply_len + 20);
- reply_buf = kmalloc(reply_len, GFP_KERNEL);
+ reply_buf = kmemdup(&(pkt->hdr), reply_len, GFP_KERNEL);
if (!skb || !reply_buf) {
kfree_skb(skb);
kfree(reply_buf);
@@ -279,7 +279,6 @@ static int iwl_test_fw_cmd(struct iwl_test *tst, struct nlattr **tb)
}
/* The reply is in a page, that we cannot send to user space. */
- memcpy(reply_buf, &(pkt->hdr), reply_len);
iwl_free_resp(&cmd);
if (nla_put_u32(skb, IWL_TM_ATTR_COMMAND,
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] wireless:iwlwifi: changed kmalloc+memcpy with kmemdup
2013-03-10 13:22 [PATCH] wireless:iwlwifi: changed kmalloc+memcpy with kmemdup Andrei Epure
@ 2013-03-10 15:10 ` Johannes Berg
2013-03-10 15:18 ` Johannes Berg
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2013-03-10 15:10 UTC (permalink / raw)
To: Andrei Epure
Cc: wey-yi.w.guy, ilw, linville, linux-wireless, netdev, linux-kernel
Applied.
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wireless:iwlwifi: changed kmalloc+memcpy with kmemdup
2013-03-10 13:22 [PATCH] wireless:iwlwifi: changed kmalloc+memcpy with kmemdup Andrei Epure
2013-03-10 15:10 ` Johannes Berg
@ 2013-03-10 15:18 ` Johannes Berg
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2013-03-10 15:18 UTC (permalink / raw)
To: Andrei Epure
Cc: wey-yi.w.guy, ilw, linville, linux-wireless, netdev, linux-kernel
Applied.
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-10 15:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-10 13:22 [PATCH] wireless:iwlwifi: changed kmalloc+memcpy with kmemdup Andrei Epure
2013-03-10 15:10 ` Johannes Berg
2013-03-10 15:18 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).