netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Yuval Mintz" <yuvalmin@broadcom.com>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: eilong@broadcom.com, ariele@broadcom.com,
	"Yuval Mintz" <yuvalmin@broadcom.com>
Subject: [PATCH net-next 11/13] bnx2x: Avoid using zero MAC
Date: Mon, 11 Mar 2013 17:17:51 +0200	[thread overview]
Message-ID: <1363015073-25743-12-git-send-email-yuvalmin@broadcom.com> (raw)
In-Reply-To: <1363015073-25743-1-git-send-email-yuvalmin@broadcom.com>

Prevent bnx2x devices which are used mainly for storage from using zero
MAC addresses as their primary MAC address.

Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Ariel Elior <ariele@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |   12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index f685d2e..e5662a1 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -10832,14 +10832,12 @@ static void bnx2x_get_cnic_mac_hwinfo(struct bnx2x *bp)
 			}
 		}
 
-		if (IS_MF_STORAGE_SD(bp))
-			/* Zero primary MAC configuration */
-			memset(bp->dev->dev_addr, 0, ETH_ALEN);
-
-		if (IS_MF_FCOE_AFEX(bp) || IS_MF_FCOE_SD(bp))
-			/* use FIP MAC as primary MAC */
+		/* If this is a storage-only interface, use SAN mac as
+		 * primary MAC. Notice that for SD this is already the case,
+		 * as the SAN mac was copied from the primary MAC.
+		 */
+		if (IS_MF_FCOE_AFEX(bp))
 			memcpy(bp->dev->dev_addr, fip_mac, ETH_ALEN);
-
 	} else {
 		val2 = SHMEM_RD(bp, dev_info.port_hw_config[port].
 				iscsi_mac_upper);
-- 
1.7.7.2

  parent reply	other threads:[~2013-03-11 16:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-11 15:17 [PATCH net-next 0/13] bnx2x: patch series Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 01/13] bnx2x: fix vlan-mac memory leak Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 02/13] bnx2x: Set ethtool ops for vfs Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 03/13] bnx2x: Take chip version from MFW Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 04/13] bnx2x: Prevent "Unknown MF" print in SF mode Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 05/13] bnx2x: Add iproute2 support for vfs Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 06/13] bnx2x: Control number of vfs dynamically Yuval Mintz
2013-03-12  9:28   ` David Miller
2013-03-12 10:51     ` Ariel Elior
2013-03-12 11:50       ` David Miller
2013-03-11 15:17 ` [PATCH net-next 07/13] bnx2x: Get gso_segs from FW Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 08/13] bnx2x: Add RJ45 SFP module detection Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 09/13] bnx2x: Add EEE support for BCM84834 Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 10/13] bnx2x: Control SFP+ tap values via nvm config Yuval Mintz
2013-03-11 15:17 ` Yuval Mintz [this message]
2013-03-11 15:17 ` [PATCH net-next 12/13] bnx2x: use FW 7.8.17 Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 13/13] bnx2x: Restore FCoE 4-port devices support Yuval Mintz
2013-03-12 11:58 ` [PATCH net-next 0/13] bnx2x: patch series David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363015073-25743-12-git-send-email-yuvalmin@broadcom.com \
    --to=yuvalmin@broadcom.com \
    --cc=ariele@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=eilong@broadcom.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).