netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Yuval Mintz" <yuvalmin@broadcom.com>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: eilong@broadcom.com, ariele@broadcom.com,
	"Yaniv Rosner" <yanivr@broadcom.com>,
	"Yuval Mintz" <yuvalmin@broadcom.com>
Subject: [PATCH net-next 08/13] bnx2x: Add RJ45 SFP module detection
Date: Mon, 11 Mar 2013 17:17:48 +0200	[thread overview]
Message-ID: <1363015073-25743-9-git-send-email-yuvalmin@broadcom.com> (raw)
In-Reply-To: <1363015073-25743-1-git-send-email-yuvalmin@broadcom.com>

From: Yaniv Rosner <yanivr@broadcom.com>

Add RJ45 SFP module detection. In case the user set 10G link speed, and the
module doesn't support it, then force the speed to 1G and notify the user.

Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c |   21 +++++++++++++--------
 1 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
index 31c5787..600f850 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
@@ -152,6 +152,7 @@
 #define SFP_EEPROM_CON_TYPE_ADDR		0x2
 	#define SFP_EEPROM_CON_TYPE_VAL_LC	0x7
 	#define SFP_EEPROM_CON_TYPE_VAL_COPPER	0x21
+	#define SFP_EEPROM_CON_TYPE_VAL_RJ45	0x22
 
 
 #define SFP_EEPROM_COMP_CODE_ADDR		0x3
@@ -8049,20 +8050,24 @@ static int bnx2x_get_edc_mode(struct bnx2x_phy *phy,
 		break;
 	}
 	case SFP_EEPROM_CON_TYPE_VAL_LC:
+	case SFP_EEPROM_CON_TYPE_VAL_RJ45:
 		check_limiting_mode = 1;
 		if ((val[1] & (SFP_EEPROM_COMP_CODE_SR_MASK |
 			       SFP_EEPROM_COMP_CODE_LR_MASK |
 			       SFP_EEPROM_COMP_CODE_LRM_MASK)) == 0) {
-			DP(NETIF_MSG_LINK, "1G Optic module detected\n");
+			DP(NETIF_MSG_LINK, "1G SFP module detected\n");
 			gport = params->port;
 			phy->media_type = ETH_PHY_SFP_1G_FIBER;
-			phy->req_line_speed = SPEED_1000;
-			if (!CHIP_IS_E1x(bp))
-				gport = BP_PATH(bp) + (params->port << 1);
-			netdev_err(bp->dev, "Warning: Link speed was forced to 1000Mbps."
-			      " Current SFP module in port %d is not"
-			      " compliant with 10G Ethernet\n",
-			 gport);
+			if (phy->req_line_speed != SPEED_1000) {
+				phy->req_line_speed = SPEED_1000;
+				if (!CHIP_IS_E1x(bp)) {
+					gport = BP_PATH(bp) +
+					(params->port << 1);
+				}
+				netdev_err(bp->dev,
+					   "Warning: Link speed was forced to 1000Mbps. Current SFP module in port %d is not compliant with 10G Ethernet\n",
+					   gport);
+			}
 		} else {
 			int idx, cfg_idx = 0;
 			DP(NETIF_MSG_LINK, "10G Optic module detected\n");
-- 
1.7.7.2

  parent reply	other threads:[~2013-03-11 16:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-11 15:17 [PATCH net-next 0/13] bnx2x: patch series Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 01/13] bnx2x: fix vlan-mac memory leak Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 02/13] bnx2x: Set ethtool ops for vfs Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 03/13] bnx2x: Take chip version from MFW Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 04/13] bnx2x: Prevent "Unknown MF" print in SF mode Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 05/13] bnx2x: Add iproute2 support for vfs Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 06/13] bnx2x: Control number of vfs dynamically Yuval Mintz
2013-03-12  9:28   ` David Miller
2013-03-12 10:51     ` Ariel Elior
2013-03-12 11:50       ` David Miller
2013-03-11 15:17 ` [PATCH net-next 07/13] bnx2x: Get gso_segs from FW Yuval Mintz
2013-03-11 15:17 ` Yuval Mintz [this message]
2013-03-11 15:17 ` [PATCH net-next 09/13] bnx2x: Add EEE support for BCM84834 Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 10/13] bnx2x: Control SFP+ tap values via nvm config Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 11/13] bnx2x: Avoid using zero MAC Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 12/13] bnx2x: use FW 7.8.17 Yuval Mintz
2013-03-11 15:17 ` [PATCH net-next 13/13] bnx2x: Restore FCoE 4-port devices support Yuval Mintz
2013-03-12 11:58 ` [PATCH net-next 0/13] bnx2x: patch series David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363015073-25743-9-git-send-email-yuvalmin@broadcom.com \
    --to=yuvalmin@broadcom.com \
    --cc=ariele@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=eilong@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=yanivr@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).