From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: [PATCH] net: ethernet: cpsw: fix usage of cpdma_check_free_tx_desc() Date: Tue, 12 Mar 2013 17:31:19 +0100 Message-ID: <1363105879-26921-1-git-send-email-zonque@gmail.com> Cc: andreas.fenkart@streamunlimited.com, davem@davemloft.net, s.neumann@raumfeld.com, koen@dominion.thruhere.net, Daniel Mack , Mugunthan V N To: netdev@vger.kernel.org Return-path: Received: from svenfoo.org ([82.94.215.22]:41805 "EHLO mail.zonque.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755559Ab3CLQbw (ORCPT ); Tue, 12 Mar 2013 12:31:52 -0400 Sender: netdev-owner@vger.kernel.org List-ID: Commit fae50823d0 ("net: ethernet: davinci_cpdma: Add boundary for rx and tx descriptors") introduced a function to check the current allocation state of tx packets. The return value is taken into account to stop the netqork queue on the adapter in case there are no free slots. However, cpdma_check_free_tx_desc() returns 'true' if there is room in the bitmap, not 'false', so the usage of the function is wrong. Signed-off-by: Daniel Mack Cc: Mugunthan V N Reported-by: Sven Neumann Reported-by: Andreas Fenkart --- drivers/net/ethernet/ti/cpsw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 01ffbc4..75c4855 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -905,7 +905,7 @@ static netdev_tx_t cpsw_ndo_start_xmit(struct sk_buff *skb, /* If there is no more tx desc left free then we need to * tell the kernel to stop sending us tx frames. */ - if (unlikely(cpdma_check_free_tx_desc(priv->txch))) + if (unlikely(!cpdma_check_free_tx_desc(priv->txch))) netif_stop_queue(ndev); return NETDEV_TX_OK; -- 1.8.1.4