* [PATCH] igb: SR-IOV init reordering
@ 2013-03-12 21:25 Alex Williamson
2013-03-13 7:51 ` Jeff Kirsher
0 siblings, 1 reply; 2+ messages in thread
From: Alex Williamson @ 2013-03-12 21:25 UTC (permalink / raw)
To: gregory.v.rose, jeffrey.t.kirsher; +Cc: netdev, ddutile, linux-kernel, sassmann
igb is ineffective at setting a lower total VFs because:
int pci_sriov_set_totalvfs(struct pci_dev *dev, u16 numvfs)
{
...
/* Shouldn't change if VFs already enabled */
if (dev->sriov->ctrl & PCI_SRIOV_CTRL_VFE)
return -EBUSY;
Swap init ordering.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index d5b8289..ac65c39 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -2546,8 +2546,8 @@ static void igb_probe_vfs(struct igb_adapter *adapter)
if ((hw->mac.type == e1000_i210) || (hw->mac.type == e1000_i211))
return;
- igb_enable_sriov(pdev, max_vfs);
pci_sriov_set_totalvfs(pdev, 7);
+ igb_enable_sriov(pdev, max_vfs);
#endif /* CONFIG_PCI_IOV */
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] igb: SR-IOV init reordering
2013-03-12 21:25 [PATCH] igb: SR-IOV init reordering Alex Williamson
@ 2013-03-13 7:51 ` Jeff Kirsher
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Kirsher @ 2013-03-13 7:51 UTC (permalink / raw)
To: Alex Williamson; +Cc: gregory.v.rose, netdev, ddutile, linux-kernel, sassmann
[-- Attachment #1: Type: text/plain, Size: 610 bytes --]
On Tue, 2013-03-12 at 15:25 -0600, Alex Williamson wrote:
> igb is ineffective at setting a lower total VFs because:
>
> int pci_sriov_set_totalvfs(struct pci_dev *dev, u16 numvfs)
> {
> ...
> /* Shouldn't change if VFs already enabled */
> if (dev->sriov->ctrl & PCI_SRIOV_CTRL_VFE)
> return -EBUSY;
>
> Swap init ordering.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I have added the patch to my igb queue, thanks!
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-13 7:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-12 21:25 [PATCH] igb: SR-IOV init reordering Alex Williamson
2013-03-13 7:51 ` Jeff Kirsher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).