From: Eric Dumazet <eric.dumazet@gmail.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Ben Hutchings <bhutchings@solarflare.com>,
Network Development <netdev@vger.kernel.org>
Subject: Re: LRO/GRO and libpcap packet reordering
Date: Fri, 15 Mar 2013 00:16:20 +0100 [thread overview]
Message-ID: <1363302980.29475.45.camel@edumazet-glaptop> (raw)
In-Reply-To: <CALCETrUpVKLr0i_3MZS_=dbxMGFzPYkpQh8qrzYqHFbjVqaKAg@mail.gmail.com>
On Thu, 2013-03-14 at 15:58 -0700, Andy Lutomirski wrote:
> Right. This is the part that I'm wondering about an efficient fix to
> (i.e. flush GRO state for one flow whenever a packet for the reversed
> flow is seen).
It doesnt seem doable easily, because network header and tcp headers are
handled in two separate functions in GRO stack (inet_gro_receive() &
tcp_gro_receive()
What you could do is changing MAX_GRO_SKBS from 8 to 1
(basically allowing only one flow in GRO stack)
next prev parent reply other threads:[~2013-03-14 23:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 20:37 LRO/GRO and libpcap packet reordering Andy Lutomirski
2013-03-14 21:58 ` Ben Hutchings
2013-03-14 22:45 ` Andy Lutomirski
2013-03-14 22:54 ` Eric Dumazet
2013-03-14 22:58 ` Andy Lutomirski
2013-03-14 23:16 ` Eric Dumazet [this message]
2013-03-14 23:21 ` Eric Dumazet
2013-03-14 23:22 ` Andy Lutomirski
2013-03-14 23:01 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363302980.29475.45.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox