From: Jesse Gross <jesse@nicira.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, dev@openvswitch.org,
Rich Lane <rlane@bigswitch.com>, Jesse Gross <jesse@nicira.com>
Subject: [PATCH net 1/6] openvswitch: Fix ovs_vport_cmd_del return value on success
Date: Thu, 14 Mar 2013 17:15:01 -0700 [thread overview]
Message-ID: <1363306506-885-2-git-send-email-jesse@nicira.com> (raw)
In-Reply-To: <1363306506-885-1-git-send-email-jesse@nicira.com>
From: Rich Lane <rlane@bigswitch.com>
If the pointer does not represent an error then the PTR_ERR macro may still
return a nonzero value. The fix is the same as in ovs_vport_cmd_set.
Signed-off-by: Rich Lane <rlane@bigswitch.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
---
net/openvswitch/datapath.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
index f996db3..5e275b9 100644
--- a/net/openvswitch/datapath.c
+++ b/net/openvswitch/datapath.c
@@ -1772,6 +1772,7 @@ static int ovs_vport_cmd_del(struct sk_buff *skb, struct genl_info *info)
if (IS_ERR(reply))
goto exit_unlock;
+ err = 0;
ovs_dp_detach_port(vport);
genl_notify(reply, genl_info_net(info), info->snd_portid,
--
1.7.10.4
next prev parent reply other threads:[~2013-03-15 0:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 0:15 [GIT net] Open vSwitch Jesse Gross
2013-03-15 0:15 ` Jesse Gross [this message]
[not found] ` <1363306506-885-1-git-send-email-jesse-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
2013-03-15 0:15 ` [PATCH net 2/6] openvswitch: Fix ovs_vport_cmd_new return value on success Jesse Gross
2013-03-15 0:15 ` [PATCH net 3/6] openvswitch: Call genlmsg_end in queue_userspace_packet Jesse Gross
2013-03-15 0:15 ` [PATCH net 4/6] openvswitch: Fix parsing invalid LLC/SNAP ethertypes Jesse Gross
2013-03-15 0:15 ` [PATCH net 5/6] openvswitch: fix the calculation of checksum for vlan header Jesse Gross
2013-03-15 0:15 ` [PATCH net 6/6] openvswitch: remove some useless comments Jesse Gross
2013-03-15 13:01 ` [GIT net] Open vSwitch David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363306506-885-2-git-send-email-jesse@nicira.com \
--to=jesse@nicira.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=netdev@vger.kernel.org \
--cc=rlane@bigswitch.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).