From: Eric Dumazet <eric.dumazet@gmail.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Sasha Levin <sasha.levin@oracle.com>,
vyasevich@gmail.com, sri@us.ibm.com,
"David S. Miller" <davem@davemloft.net>,
linux-sctp@vger.kernel.org, netdev@vger.kernel.org,
Dave Jones <davej@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: sctp: hang in sctp_remaddr_seq_show
Date: Mon, 18 Mar 2013 08:25:40 -0700 [thread overview]
Message-ID: <1363620340.29475.132.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130318110415.GA9478@hmsreliant.think-freely.org>
On Mon, 2013-03-18 at 07:04 -0400, Neil Horman wrote:
> I'm not sure why the process would never get back to the schedule, but looking
> at the sctp_remaddr_seq_show function, I think that we should convert this
> sequence:
> sctp_local_bh_disable();
> read_lock(&head->lock);
> rcu_read_lock();
>
> to this:
> read_lock(&head->lock);
> rcu_read_lock_bh();
>
> Neil
I dont think so.
BH needs to be disabled before read_lock(&head->lock);
or else, write_lock() could deadlock (assuming it can be called from BH)
next prev parent reply other threads:[~2013-03-18 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 16:34 sctp: hang in sctp_remaddr_seq_show Sasha Levin
2013-03-18 11:04 ` Neil Horman
2013-03-18 15:25 ` Eric Dumazet [this message]
2013-03-18 15:31 ` Vlad Yasevich
2013-03-18 20:32 ` Neil Horman
2013-03-18 20:39 ` Vlad Yasevich
2013-03-18 20:48 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363620340.29475.132.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=sasha.levin@oracle.com \
--cc=sri@us.ibm.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox