From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Maciej Żenczykowski" <zenczykowski@gmail.com>
Cc: David Miller <davem@davemloft.net>,
eilong@broadcom.com, dmitry@broadcom.com, netdev@vger.kernel.org,
yuvalmin@broadcom.com
Subject: Re: [PATCH] bnx2x: fix occasional statistics off-by-4GB error
Date: Mon, 18 Mar 2013 13:35:17 -0700 [thread overview]
Message-ID: <1363638917.21184.3.camel@edumazet-glaptop> (raw)
In-Reply-To: <CAHo-OowoWD_BT2W8ok32pcSmcshXttpErna-X92Ojz_A8es8iw@mail.gmail.com>
On Mon, 2013-03-18 at 13:06 -0700, Maciej Żenczykowski wrote:
> Current best guess is UPDATE_ESTAT_QSTAT_64 which uses SUB_64
> implemented via DIFF_64 which is crazy.
All these macros are really ugly, I wish someone could cleanup this
code.
next prev parent reply other threads:[~2013-03-18 20:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 21:03 bnx2x statistics occasionally wrong by near multiples of 4GB Maciej Żenczykowski
2013-03-15 21:56 ` [PATCH] bnx2x: fix occasional statistics off-by-4GB error Maciej Żenczykowski
2013-03-17 13:10 ` Dmitry Kravkov
2013-03-17 18:24 ` David Miller
2013-03-17 19:37 ` Eilon Greenstein
2013-03-17 20:25 ` Eric Dumazet
2013-03-17 20:53 ` Eilon Greenstein
2013-03-17 23:17 ` Eric Dumazet
2013-03-18 7:27 ` Eilon Greenstein
2013-03-18 6:18 ` Maciej Żenczykowski
2013-03-18 10:06 ` Eilon Greenstein
2013-03-18 17:13 ` David Miller
2013-03-18 19:54 ` Maciej Żenczykowski
2013-03-18 20:05 ` David Miller
2013-03-18 20:06 ` Maciej Żenczykowski
2013-03-18 20:35 ` Eric Dumazet [this message]
2013-03-18 20:36 ` Maciej Żenczykowski
2013-03-21 21:23 ` Maciej Żenczykowski
2013-03-21 21:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363638917.21184.3.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=yuvalmin@broadcom.com \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox