From: Eric Dumazet <eric.dumazet@gmail.com>
To: Daniel Borkmann <dborkman@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, jasowang@redhat.com
Subject: Re: [PATCH v2 net-next 1/4] flow_keys: include thoff into flow_keys for later usage
Date: Tue, 19 Mar 2013 08:03:10 -0700 [thread overview]
Message-ID: <1363705390.2558.3.camel@edumazet-glaptop> (raw)
In-Reply-To: <cc0d2911a173be99651dc39e77286aab260c3c19.1363702456.git.dborkman@redhat.com>
On Tue, 2013-03-19 at 15:34 +0100, Daniel Borkmann wrote:
> In skb_flow_dissect(), we perform a dissection of a skbuff. Since we're
> doing the work here anyway, also store thoff for a later usage, e.g. in
> the BPF filter. Also, by having thoff 16 Bit, we do not need to pack
> flow_keys and reorder choke_skb_cb.
>
> Suggested-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
> ---
> This patch also needs to go into the net tree, since Eric or Jason will
> post a bug fix on top of this one.
>
> include/net/flow_keys.h | 1 +
> net/core/flow_dissector.c | 5 ++++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
Oh well, you left the choke_skb_cb description in changelog
Acked-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2013-03-19 15:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 14:33 [PATCH v2 net-next 0/4] net: filter: BPF updates Daniel Borkmann
2013-03-19 14:34 ` [PATCH v2 net-next 1/4] flow_keys: include thoff into flow_keys for later usage Daniel Borkmann
2013-03-19 15:03 ` Eric Dumazet [this message]
2013-03-19 15:06 ` Daniel Borkmann
2013-03-19 15:38 ` Eric Dumazet
2013-03-19 14:34 ` [PATCH v2 net-next 2/4] net: flow_dissector: add __skb_get_poff to get a start offset to payload Daniel Borkmann
2013-03-19 15:03 ` Eric Dumazet
2013-03-19 14:34 ` [PATCH v2 net-next 3/4] filter: add ANC_PAY_OFFSET instruction for loading payload start offset Daniel Borkmann
2013-03-19 15:04 ` Eric Dumazet
2013-03-19 14:34 ` [PATCH v2 net-next 4/4] filter: add minimal BPF JIT emitted image disassembler Daniel Borkmann
2013-03-19 15:05 ` Eric Dumazet
2013-03-19 14:38 ` [PATCH v2 net-next 0/4] net: filter: BPF updates David Miller
2013-03-19 14:42 ` Daniel Borkmann
2013-03-19 14:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363705390.2558.3.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=jasowang@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox