From: Shahed Shaikh <shahed.shaikh@qlogic.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Dept_NX_Linux_NIC_Driver@qlogic.com,
Himanshu Madhani <himanshu.madhani@qlogic.com>
Subject: [PATCH net-next 2/5] qlcnic: Log warning message for 83xx adapter in MSI mode.
Date: Fri, 22 Mar 2013 11:57:54 -0400 [thread overview]
Message-ID: <1363967877-16812-3-git-send-email-shahed.shaikh@qlogic.com> (raw)
In-Reply-To: <1363967877-16812-1-git-send-email-shahed.shaikh@qlogic.com>
From: Himanshu Madhani <himanshu.madhani@qlogic.com>
o 83xx adapter does not support MSI interrupts, display
warning whenever module parameter is used to load driver
in MSI mode.
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
Signed-off-by: Shahed Shaikh <shahed.shaikh@qlogic.com>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index c6f9d5e..d980723 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -1923,6 +1923,12 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
module_name(THIS_MODULE),
board_name, adapter->ahw->revision_id);
}
+
+ if (qlcnic_83xx_check(adapter) && !qlcnic_use_msi_x &&
+ !!qlcnic_use_msi)
+ dev_warn(&pdev->dev,
+ "83xx adapter do not support MSI interrupts\n");
+
err = qlcnic_setup_intr(adapter, 0);
if (err) {
dev_err(&pdev->dev, "Failed to setup interrupt\n");
--
1.5.6
next prev parent reply other threads:[~2013-03-22 16:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 15:57 [PATCH net-next 0/5] qlcnic: bug fixes and log enhancement Shahed Shaikh
2013-03-22 15:57 ` [PATCH net-next 1/5] qlcnic: Fix configure mailbox interrupt command for 83xx adapter Shahed Shaikh
2013-03-22 15:57 ` Shahed Shaikh [this message]
2013-03-22 15:57 ` [PATCH net-next 3/5] qlcnic: change mdelay to msleep Shahed Shaikh
2013-03-22 15:57 ` [PATCH net-next 4/5] qlcnic: Clear link status when interface is down Shahed Shaikh
2013-03-22 15:57 ` [PATCH net-next 5/5] qlcnic: Bump up the version to 5.1.38 Shahed Shaikh
2013-03-22 16:47 ` [PATCH net-next 0/5] qlcnic: bug fixes and log enhancement David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363967877-16812-3-git-send-email-shahed.shaikh@qlogic.com \
--to=shahed.shaikh@qlogic.com \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=davem@davemloft.net \
--cc=himanshu.madhani@qlogic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).