From: Eric Dumazet <eric.dumazet@gmail.com>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, Patrick McHardy <kaber@trash.net>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next] 8021q: fix a potential use-after-free
Date: Sat, 23 Mar 2013 08:16:06 -0700 [thread overview]
Message-ID: <1364051766.4431.86.camel@edumazet-glaptop> (raw)
In-Reply-To: <1364015648-4195-1-git-send-email-amwang@redhat.com>
On Sat, 2013-03-23 at 13:14 +0800, Cong Wang wrote:
> From: Cong Wang <amwang@redhat.com>
>
> vlan_vid_del() could possibly free ->vlan_info after a RCU grace
> period, however, we may still refer to the freed memory area
> by 'grp' pointer. Found by code inspection.
>
> This patch moves vlan_vid_del() as behind as possible.
>
> Cc: Patrick McHardy <kaber@trash.net>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Cong Wang <amwang@redhat.com>
> ---
> net/8021q/vlan.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
Acked-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2013-03-23 15:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 7:50 [Patch net-next] ip_gre: increase inner ip header ID during segmentation Cong Wang
2013-03-22 7:57 ` Cong Wang
2013-03-22 10:31 ` [PATCH net-next 1/2] " Cong Wang
2013-03-22 10:31 ` [PATCH net-next 2/2] udp: " Cong Wang
2013-03-22 14:24 ` David Miller
2013-03-22 14:24 ` [PATCH net-next 1/2] ip_gre: " David Miller
2013-03-22 17:12 ` Pravin Shelar
2013-03-23 3:25 ` Cong Wang
2013-03-23 5:14 ` [PATCH net-next] 8021q: fix a potential use-after-free Cong Wang
2013-03-23 5:14 ` [PATCH net-next] 802: fix a possible race condition Cong Wang
2013-03-24 21:24 ` David Miller
2013-03-25 13:32 ` Cong Wang
2013-03-25 14:08 ` Eric Dumazet
2013-03-26 3:01 ` Cong Wang
2013-03-23 15:16 ` Eric Dumazet [this message]
2013-03-24 21:27 ` [PATCH net-next] 8021q: fix a potential use-after-free David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364051766.4431.86.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox