From: Wei Liu <wei.liu2@citrix.com>
To: <xen-devel@lists.xen.org>, <netdev@vger.kernel.org>
Cc: <ian.campbell@citrix.com>, <annie.li@oracle.com>,
<konrad.wilk@oracle.com>, <david.vrabel@citrix.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: [PATCH 4/6] xen-netback: remove skb in xen_netbk_alloc_page
Date: Mon, 25 Mar 2013 11:08:20 +0000 [thread overview]
Message-ID: <1364209702-12437-5-git-send-email-wei.liu2@citrix.com> (raw)
In-Reply-To: <1364209702-12437-1-git-send-email-wei.liu2@citrix.com>
This variable is never used.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---
drivers/net/xen-netback/netback.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index da726a3..6e8e51a 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -948,7 +948,6 @@ static int netbk_count_requests(struct xenvif *vif,
}
static struct page *xen_netbk_alloc_page(struct xen_netbk *netbk,
- struct sk_buff *skb,
u16 pending_idx)
{
struct page *page;
@@ -982,7 +981,7 @@ static struct gnttab_copy *xen_netbk_get_requests(struct xen_netbk *netbk,
index = pending_index(netbk->pending_cons++);
pending_idx = netbk->pending_ring[index];
- page = xen_netbk_alloc_page(netbk, skb, pending_idx);
+ page = xen_netbk_alloc_page(netbk, pending_idx);
if (!page)
goto err;
@@ -1387,7 +1386,7 @@ static unsigned xen_netbk_tx_build_gops(struct xen_netbk *netbk)
}
/* XXX could copy straight to head */
- page = xen_netbk_alloc_page(netbk, skb, pending_idx);
+ page = xen_netbk_alloc_page(netbk, pending_idx);
if (!page) {
kfree_skb(skb);
netbk_tx_err(vif, &txreq, idx);
--
1.7.10.4
next prev parent reply other threads:[~2013-03-25 11:09 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 11:08 [PATCH 0/6 V2] Bundle fixes for Xen netfront / netback Wei Liu
2013-03-25 11:08 ` [PATCH 1/6] xen-netfront: remove unused variable `extra' Wei Liu
2013-03-25 14:21 ` [Xen-devel] " David Vrabel
2013-03-25 16:20 ` David Miller
2013-03-25 11:08 ` [PATCH 2/6] xen-netfront: reduce gso_max_size to account for ethernet header Wei Liu
2013-03-25 14:23 ` [Xen-devel] " David Vrabel
2013-03-25 14:39 ` Jan Beulich
2013-03-25 15:50 ` Sergei Shtylyov
2013-03-25 16:18 ` David Miller
2013-03-25 16:54 ` Eric Dumazet
2013-03-25 16:59 ` David Miller
2013-03-25 17:24 ` Eric Dumazet
2013-03-25 20:49 ` Ben Hutchings
2013-03-25 18:32 ` Wei Liu
2013-03-25 18:39 ` David Miller
2013-03-25 16:56 ` Konrad Rzeszutek Wilk
2013-03-25 11:08 ` [PATCH 3/6] xen-netfront: frags -> slots in xennet_get_responses Wei Liu
2013-03-25 14:25 ` [Xen-devel] " David Vrabel
2013-03-25 16:20 ` David Miller
2013-03-25 11:08 ` Wei Liu [this message]
2013-03-25 16:20 ` [PATCH 4/6] xen-netback: remove skb in xen_netbk_alloc_page David Miller
2013-03-25 11:08 ` [PATCH 5/6] xen-netback: coalesce slots before copying Wei Liu
2013-03-25 15:13 ` David Vrabel
2013-03-25 15:47 ` [Xen-devel] " Wei Liu
2013-03-25 16:34 ` David Vrabel
2013-03-25 16:58 ` Wei Liu
2013-03-25 17:06 ` [Xen-devel] " Wei Liu
2013-03-25 18:29 ` David Vrabel
2013-03-25 19:09 ` Wei Liu
2013-03-26 9:16 ` Paul Durrant
2013-03-26 9:51 ` Wei Liu
2013-03-26 11:00 ` James Harper
2013-03-26 11:24 ` Paul Durrant
2013-03-26 11:29 ` James Harper
2013-03-26 11:38 ` Paul Durrant
2013-03-26 11:27 ` David Laight
2013-03-26 10:52 ` James Harper
2013-03-26 11:06 ` David Vrabel
2013-03-26 11:15 ` James Harper
2013-03-26 11:13 ` David Vrabel
2013-03-26 11:29 ` Wei Liu
2013-03-25 16:20 ` David Miller
2013-03-25 16:57 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-04-09 15:10 ` Ian Campbell
2013-03-26 18:02 ` David Vrabel
2013-03-25 11:08 ` [PATCH 6/6] xen-netback: don't disconnect frontend when seeing oversize frame Wei Liu
2013-03-25 11:47 ` David Vrabel
2013-03-25 12:00 ` Wei Liu
2013-03-25 12:53 ` [Xen-devel] " Jan Beulich
2013-03-25 13:52 ` Wei Liu
2013-03-25 16:21 ` David Miller
2013-03-25 16:58 ` [Xen-devel] " Konrad Rzeszutek Wilk
2013-03-27 10:03 ` William Dauchy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364209702-12437-5-git-send-email-wei.liu2@citrix.com \
--to=wei.liu2@citrix.com \
--cc=annie.li@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).