* [PATCH] pch_gbe: fix ip_summed checksum reporting on rx
@ 2013-03-26 8:26 Veaceslav Falico
2013-03-26 16:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Veaceslav Falico @ 2013-03-26 8:26 UTC (permalink / raw)
To: netdev; +Cc: richardcochran, tshimizu818, vfalico, andy.cress
skb->ip_summed should be CHECKSUM_UNNECESSARY when the driver reports that
checksums were correct and CHECKSUM_NONE in any other case. They're
currently placed vice versa, which breaks the forwarding scenario. Fix it
by placing them as described above.
Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
---
.../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
index 39ab4d0..73ce7dd 100644
--- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
@@ -1726,9 +1726,9 @@ pch_gbe_clean_rx(struct pch_gbe_adapter *adapter,
skb->protocol = eth_type_trans(skb, netdev);
if (tcp_ip_status & PCH_GBE_RXD_ACC_STAT_TCPIPOK)
- skb->ip_summed = CHECKSUM_NONE;
- else
skb->ip_summed = CHECKSUM_UNNECESSARY;
+ else
+ skb->ip_summed = CHECKSUM_NONE;
napi_gro_receive(&adapter->napi, skb);
(*work_done)++;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pch_gbe: fix ip_summed checksum reporting on rx
2013-03-26 8:26 [PATCH] pch_gbe: fix ip_summed checksum reporting on rx Veaceslav Falico
@ 2013-03-26 16:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-03-26 16:21 UTC (permalink / raw)
To: vfalico; +Cc: netdev, richardcochran, tshimizu818, andy.cress
From: Veaceslav Falico <vfalico@redhat.com>
Date: Tue, 26 Mar 2013 09:26:21 +0100
> skb->ip_summed should be CHECKSUM_UNNECESSARY when the driver reports that
> checksums were correct and CHECKSUM_NONE in any other case. They're
> currently placed vice versa, which breaks the forwarding scenario. Fix it
> by placing them as described above.
>
> Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-26 16:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-26 8:26 [PATCH] pch_gbe: fix ip_summed checksum reporting on rx Veaceslav Falico
2013-03-26 16:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).