* [PATCH] bonding: cleanup unneeded rcu_read_lock()
@ 2013-03-26 14:10 Veaceslav Falico
2013-03-26 16:50 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Veaceslav Falico @ 2013-03-26 14:10 UTC (permalink / raw)
To: netdev; +Cc: vfalico, andy, fubar
bond_resend_igmp_join_requests_delayed() calls _resend_igmp_join_requests()
under rcu_read_lock(), while it gets its own rcu_read_lock() for the whole
function. Remove the lock from the _delayed function.
Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
---
drivers/net/bonding/bond_main.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 6bbd90e..11a8cb3 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -796,9 +796,8 @@ static void bond_resend_igmp_join_requests_delayed(struct work_struct *work)
{
struct bonding *bond = container_of(work, struct bonding,
mcast_work.work);
- rcu_read_lock();
+
bond_resend_igmp_join_requests(bond);
- rcu_read_unlock();
}
/*
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bonding: cleanup unneeded rcu_read_lock()
2013-03-26 14:10 [PATCH] bonding: cleanup unneeded rcu_read_lock() Veaceslav Falico
@ 2013-03-26 16:50 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-03-26 16:50 UTC (permalink / raw)
To: vfalico; +Cc: netdev, andy, fubar
From: Veaceslav Falico <vfalico@redhat.com>
Date: Tue, 26 Mar 2013 15:10:02 +0100
> bond_resend_igmp_join_requests_delayed() calls _resend_igmp_join_requests()
> under rcu_read_lock(), while it gets its own rcu_read_lock() for the whole
> function. Remove the lock from the _delayed function.
>
> Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-26 16:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-26 14:10 [PATCH] bonding: cleanup unneeded rcu_read_lock() Veaceslav Falico
2013-03-26 16:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).