* [PATCH net-next 1/1] bnx2x: Fix AER semaphore release
@ 2013-03-27 9:28 Yuval Mintz
2013-03-27 17:08 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yuval Mintz @ 2013-03-27 9:28 UTC (permalink / raw)
To: davem, netdev; +Cc: eilong, Yuval Mintz, Ariel Elior
Commit 7fa6f34 "AER revised" erroneously inserted an error-flow
in which a semaphore is released even though the attempt to take it
has failed.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Ariel Elior <ariele@broadcom.com>
---
Hi Dave,
Please accept this to `net-next'.
Thanks,
Yuval
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 2c6a2a6..5c5a327 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -10070,8 +10070,8 @@ static int bnx2x_prev_unload(struct bnx2x *bp)
/* If Path is marked by EEH, ignore unload status */
aer = !!(bnx2x_prev_path_get_entry(bp) &&
bnx2x_prev_path_get_entry(bp)->aer);
+ up(&bnx2x_prev_sem);
}
- up(&bnx2x_prev_sem);
if (fw == FW_MSG_CODE_DRV_UNLOAD_COMMON || aer) {
rc = bnx2x_prev_unload_common(bp);
--
1.8.1.227.g44fe835
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next 1/1] bnx2x: Fix AER semaphore release
2013-03-27 9:28 [PATCH net-next 1/1] bnx2x: Fix AER semaphore release Yuval Mintz
@ 2013-03-27 17:08 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-03-27 17:08 UTC (permalink / raw)
To: yuvalmin; +Cc: netdev, eilong, ariele
From: "Yuval Mintz" <yuvalmin@broadcom.com>
Date: Wed, 27 Mar 2013 11:28:03 +0200
> Commit 7fa6f34 "AER revised" erroneously inserted an error-flow
> in which a semaphore is released even though the attempt to take it
> has failed.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
> Signed-off-by: Ariel Elior <ariele@broadcom.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-27 17:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-27 9:28 [PATCH net-next 1/1] bnx2x: Fix AER semaphore release Yuval Mintz
2013-03-27 17:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).