From: Hong Zhiguo <honkiko@gmail.com>
To: netdev@vger.kernel.org
Cc: dev@openvswitch.org, davem@davemloft.net,
stephen@networkplumber.org, jesse@nicira.com
Subject: [PATCH net-next] openvswitch: correct an invalid BUG_ON
Date: Wed, 27 Mar 2013 20:41:17 +0800 [thread overview]
Message-ID: <1364388077-30480-1-git-send-email-honkiko@gmail.com> (raw)
table->count is uint32_t
Signed-off-by: Hong Zhiguo <honkiko@gmail.com>
---
net/openvswitch/flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
index fe0e421..67a2b78 100644
--- a/net/openvswitch/flow.c
+++ b/net/openvswitch/flow.c
@@ -795,9 +795,9 @@ void ovs_flow_tbl_insert(struct flow_table *table, struct sw_flow *flow)
void ovs_flow_tbl_remove(struct flow_table *table, struct sw_flow *flow)
{
+ BUG_ON(table->count == 0);
hlist_del_rcu(&flow->hash_node[table->node_ver]);
table->count--;
- BUG_ON(table->count < 0);
}
/* The size of the argument for each %OVS_KEY_ATTR_* Netlink attribute. */
--
1.7.10.4
next reply other threads:[~2013-03-27 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 12:41 Hong Zhiguo [this message]
[not found] ` <1364388077-30480-1-git-send-email-honkiko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-27 15:19 ` [PATCH net-next] openvswitch: correct an invalid BUG_ON Jesse Gross
2013-03-27 16:58 ` Hong zhi guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364388077-30480-1-git-send-email-honkiko@gmail.com \
--to=honkiko@gmail.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).