Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: Balakumaran Kannan <kumaran.4353@gmail.com>,
	davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
	kaber@trash.net, netdev@vger.kernel.org,
	Balakumaran.Kannan@ap.sony.com, maruthi.thotad@ap.sony.com
Subject: Re: [PATCH] net : Fix broken IPv6 routing table after loopback down-up
Date: Wed, 27 Mar 2013 08:26:48 -0700	[thread overview]
Message-ID: <1364398008.15753.14.camel@edumazet-glaptop> (raw)
In-Reply-To: <5152D012.4030805@linux-ipv6.org>

On Wed, 2013-03-27 at 19:55 +0900, YOSHIFUJI Hideaki wrote:
> Balakumaran Kannan wrote:

> >  	add_addr(idev, &in6addr_loopback, 128, IFA_HOST);
> > +
> > +	while ((sp_dev = dev_get_by_index(dev_net(dev), i++))) {
> > +
> 
> I think this cannot work because we may have missing index.
> Why no dev_get_by_name()?

I might 'work' because lo interface index is 1 on all network
namespaces.

But yes, this ugly loop is not needed at all.

      reply	other threads:[~2013-03-27 15:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-27 10:01 [PATCH] net : Fix broken IPv6 routing table after loopback down-up Balakumaran Kannan
2013-03-27 10:55 ` YOSHIFUJI Hideaki
2013-03-27 15:26   ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364398008.15753.14.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=Balakumaran.Kannan@ap.sony.com \
    --cc=davem@davemloft.net \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kumaran.4353@gmail.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=maruthi.thotad@ap.sony.com \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox