From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: netdev@vger.kernel.org
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>
Subject: [PATCH v2 1/3] net/macb: clear tx/rx completion flags in ISR
Date: Thu, 28 Mar 2013 10:07:05 +0100 [thread overview]
Message-ID: <1364461627-26521-2-git-send-email-s.trumtrar@pengutronix.de> (raw)
In-Reply-To: <1364461627-26521-1-git-send-email-s.trumtrar@pengutronix.de>
At least in the cadence IP core on the Xilinx Zynq SoC the TCOMP/RCOMP flags
are not auto-cleaned. As these flags are evaluated, they need to be cleaned.
Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
---
drivers/net/ethernet/cadence/macb.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index 7903943..817835e 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -485,6 +485,8 @@ static void macb_tx_interrupt(struct macb *bp)
status = macb_readl(bp, TSR);
macb_writel(bp, TSR, status);
+ macb_writel(bp, ISR, MACB_BIT(TCOMP));
+
netdev_vdbg(bp->dev, "macb_tx_interrupt status = 0x%03lx\n",
(unsigned long)status);
@@ -736,6 +738,7 @@ static irqreturn_t macb_interrupt(int irq, void *dev_id)
* now.
*/
macb_writel(bp, IDR, MACB_RX_INT_FLAGS);
+ macb_writel(bp, ISR, MACB_BIT(RCOMP));
if (napi_schedule_prep(&bp->napi)) {
netdev_vdbg(bp->dev, "scheduling RX softirq\n");
--
1.8.2.rc2
next prev parent reply other threads:[~2013-03-28 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 9:07 [PATCH v2 0/3] net/macb: fixes to use core on Zynq SoCs Steffen Trumtrar
2013-03-28 9:07 ` Steffen Trumtrar [this message]
2013-03-28 9:07 ` [PATCH v2 2/3] net/macb: force endian_swp_pkt_en to off Steffen Trumtrar
2013-03-28 9:07 ` [PATCH v2 3/3] net/macb: make clk_enable atomic Steffen Trumtrar
2013-03-28 11:10 ` [PATCH v2 0/3] net/macb: fixes to use core on Zynq SoCs Nicolas Ferre
2013-03-28 11:28 ` Steffen Trumtrar
2013-03-28 18:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364461627-26521-2-git-send-email-s.trumtrar@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).