From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: Ben Greear <greearb@candelatech.com>,
netdev@vger.kernel.org, Igor Michailov <rgohita@gmail.com>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>
Subject: [PATCH] net: core: Remove redundant call to 'nf_reset' in 'dev_forward_skb'
Date: Thu, 28 Mar 2013 11:13:26 +0200 [thread overview]
Message-ID: <1364462006-5814-1-git-send-email-shmulik.ladkani@gmail.com> (raw)
'nf_reset' is called just prior calling 'netif_rx'.
No need to call it twice.
Reported-by: Igor Michailov <rgohita@gmail.com>
Signed-off-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
---
net/core/dev.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 2db88df..071f398 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1624,7 +1624,6 @@ int dev_forward_skb(struct net_device *dev, struct sk_buff *skb)
}
skb_orphan(skb);
- nf_reset(skb);
if (unlikely(!is_skb_forwardable(dev, skb))) {
atomic_long_inc(&dev->rx_dropped);
--
1.7.9
next reply other threads:[~2013-03-28 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 9:13 Shmulik Ladkani [this message]
2013-03-28 13:36 ` [PATCH] net: core: Remove redundant call to 'nf_reset' in 'dev_forward_skb' Eric Dumazet
2013-03-29 19:11 ` David Miller
2013-03-29 19:17 ` Eric Dumazet
2013-03-29 19:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364462006-5814-1-git-send-email-shmulik.ladkani@gmail.com \
--to=shmulik.ladkani@gmail.com \
--cc=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
--cc=rgohita@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).