From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [net-next PATCH 3/3] net: frag queue per hash bucket locking Date: Thu, 28 Mar 2013 16:39:42 -0700 Message-ID: <1364513982.15753.57.camel@edumazet-glaptop> References: <20130327155238.15203.6688.stgit@dragon> <20130327155601.15203.25289.stgit@dragon> <1364405159.15753.26.camel@edumazet-glaptop> <20130328185721.GA20223@order.stressinduktion.org> <1364502164.15753.56.camel@edumazet-glaptop> <20130328233002.GC20223@order.stressinduktion.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Jesper Dangaard Brouer , "David S. Miller" , netdev@vger.kernel.org, Florian Westphal , Daniel Borkmann To: Hannes Frederic Sowa Return-path: Received: from mail-pb0-f54.google.com ([209.85.160.54]:35101 "EHLO mail-pb0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751993Ab3C1Xjp (ORCPT ); Thu, 28 Mar 2013 19:39:45 -0400 Received: by mail-pb0-f54.google.com with SMTP id rq13so27544pbb.13 for ; Thu, 28 Mar 2013 16:39:44 -0700 (PDT) In-Reply-To: <20130328233002.GC20223@order.stressinduktion.org> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 2013-03-29 at 00:30 +0100, Hannes Frederic Sowa wrote: > On Thu, Mar 28, 2013 at 01:22:44PM -0700, Eric Dumazet wrote: > > On Thu, 2013-03-28 at 19:57 +0100, Hannes Frederic Sowa wrote: > > > > > I assume that it has to do with the usage of this code in > > > ipv6/netfilter/nf_conntrack_reasm.c, which could be invoked from process > > > context, if I read it correctly. > > > > Then there would be a possible deadlock in current code. > > Netfilter currently does a local_bh_disable() before entering inet_fragment > (and later enables it, again). > Good, so no need for the _bh() as I suspected.