From: Eric Dumazet <eric.dumazet@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Jiri Pirko" <jpirko@redhat.com>,
"Andy Gospodarek" <andy@greyhouse.net>,
"David S. Miller" <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
"Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Guy Streeter" <streeter@redhat.com>,
"Paul E. McKenney" <paulmck@us.ibm.com>,
stephen@networkplumber.org
Subject: Re: [PATCH] net: add a synchronize_net() in netdev_rx_handler_unregister()
Date: Fri, 29 Mar 2013 06:38:59 -0700 [thread overview]
Message-ID: <1364564339.5113.19.camel@edumazet-glaptop> (raw)
In-Reply-To: <1364563039.10629.19.camel@gandalf.local.home>
On Fri, 2013-03-29 at 09:17 -0400, Steven Rostedt wrote:
> I've thought about this too, but I wasn't sure we wanted two
> synchronize_*() functions, as the caller does a synchronize as well.
> That said, I think this is the more robust solution and it lets all
> rx_handler() functions assume that their rx_handler_data is set. And it
> removes the check from the fast path which outweighs an added
> synchronization in the slow path.
>
Note that I used synchronize_net(), which does a
synchronize_rcu_expedited() when RTNL is locked, so its normally quite
fast.
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
>
> Thanks!
Thanks a lot for your very detailed report and analysis !
next prev parent reply other threads:[~2013-03-29 13:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 17:16 [BUG] Crash with NULL pointer dereference in bond_handle_frame in -rt (possibly mainline) Steven Rostedt
2013-03-28 17:29 ` Eric Dumazet
2013-03-28 17:44 ` Steven Rostedt
2013-03-29 9:48 ` Jiri Pirko
2013-03-29 13:01 ` [PATCH] net: add a synchronize_net() in netdev_rx_handler_unregister() Eric Dumazet
2013-03-29 13:17 ` Steven Rostedt
2013-03-29 13:38 ` Eric Dumazet [this message]
2013-03-29 15:11 ` Ivan Vecera
2013-03-29 15:38 ` Eric Dumazet
2013-03-29 16:12 ` Jiri Pirko
2013-03-29 16:46 ` Eric Dumazet
2013-03-29 19:20 ` Paul E. McKenney
2013-03-29 19:26 ` Eric Dumazet
2013-03-29 19:39 ` David Miller
2013-03-29 15:46 ` [BUG] Crash with NULL pointer dereference in bond_handle_frame in -rt (possibly mainline) Stephen Hemminger
2013-03-29 18:36 ` Steven Rostedt
2013-03-29 19:55 ` Steven Rostedt
2013-03-30 9:19 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364564339.5113.19.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@gmail.com \
--cc=paulmck@us.ibm.com \
--cc=rostedt@goodmis.org \
--cc=stephen@networkplumber.org \
--cc=streeter@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox