From: Eric Dumazet <eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Jiri Pirko <jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
Cc: alexander.h.duyck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org,
paulmck-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
streeter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
nicolas.2p.debian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
fubar-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org,
kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org,
edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
ivecera-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
andy-QlMahl40kYEqcZcGjlUOXw@public.gmane.org
Subject: Re: [patch net-next] net: squash ->rx_handler and ->rx_handler_data into single rcu pointer
Date: Sat, 30 Mar 2013 12:31:03 -0700 [thread overview]
Message-ID: <1364671863.5113.122.camel@edumazet-glaptop> (raw)
In-Reply-To: <1364671688.5113.119.camel@edumazet-glaptop>
On Sat, 2013-03-30 at 12:28 -0700, Eric Dumazet wrote:
> On Sat, 2013-03-30 at 18:13 +0100, Jiri Pirko wrote:
>
> > Well, not entirely true, depends on arch.
> >
>
> Are you really trying to obfuscate stack because of Alpha architecture ?
By the way, only dev->rx_handler needs to be RCU protected.
The patch send yesterday make the second rcu_dereference() (to get
rx_handler_data) totally irrelevant.
next prev parent reply other threads:[~2013-03-30 19:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-30 15:57 [patch net-next] net: squash ->rx_handler and ->rx_handler_data into single rcu pointer Jiri Pirko
[not found] ` <1364659034-7049-1-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2013-03-30 16:23 ` Eric Dumazet
2013-03-30 17:13 ` Jiri Pirko
[not found] ` <20130330171325.GC1544-RDzucLLXGGI88b5SBfVpbw@public.gmane.org>
2013-03-30 19:28 ` Eric Dumazet
2013-03-30 19:31 ` Eric Dumazet [this message]
2013-03-30 19:32 ` Eric Dumazet
2013-03-30 19:24 ` Steven Rostedt
[not found] ` <f72ccc9e-b09e-4abb-a0ce-a6516138b25c-2ueSQiBKiTY7tOexoI0I+QC/G2K4zDHf@public.gmane.org>
2013-03-30 19:32 ` Jiri Pirko
[not found] ` <20130330193210.GD1544-RDzucLLXGGI88b5SBfVpbw@public.gmane.org>
2013-04-08 16:32 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364671863.5113.122.camel@edumazet-glaptop \
--to=eric.dumazet-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=alexander.h.duyck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=andy-QlMahl40kYEqcZcGjlUOXw@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org \
--cc=edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=fubar-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=ivecera-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org \
--cc=kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nicolas.2p.debian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=paulmck-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
--cc=streeter-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox