From: Eric Dumazet <eric.dumazet@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: RongQing Li <roy.qing.li@gmail.com>,
Shan Wei <davidshan@tencent.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] core: fix the use of this_cpu_ptr
Date: Mon, 01 Apr 2013 09:31:27 -0700 [thread overview]
Message-ID: <1364833887.5113.161.camel@edumazet-glaptop> (raw)
In-Reply-To: <0000013dc6307f44-940f2bf1-7556-4d9e-92ab-1a84d2a47ca8-000000@email.amazonses.com>
On Mon, 2013-04-01 at 15:21 +0000, Christoph Lameter wrote:
> On Fri, 29 Mar 2013, RongQing Li wrote:
> > flush_tasklet is not a percpu var, it is a member of percpu var.
>
> Well then it would be best to use this_cpu_read() instead of this_cpu_ptr.
> It also will generate better code.
I believe we already had this discussion in the past.
flush_tasklet is a structure, and we need its address, not read its
content.
You can not use this_cpu_read() to get its address, and following
code is fine.
tasklet = &this_cpu_ptr(info->cache->percpu)->flush_tasklet;
Similar to this code in mm/page_alloc.c
pcp = &this_cpu_ptr(zone->pageset)->pcp;
next prev parent reply other threads:[~2013-04-01 16:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 9:42 [PATCH] core: fix the use of this_cpu_ptr roy.qing.li
2013-03-28 13:05 ` Eric Dumazet
2013-03-28 14:38 ` Christoph Lameter
2013-03-28 15:36 ` Eric Dumazet
2013-03-28 16:44 ` Christoph Lameter
2013-03-29 1:24 ` RongQing Li
2013-04-01 15:21 ` Christoph Lameter
2013-04-01 16:31 ` Eric Dumazet [this message]
2013-04-01 18:15 ` Christoph Lameter
2013-04-03 20:41 ` this cpu documentation Christoph Lameter
2013-04-03 21:18 ` Tejun Heo
2013-04-04 0:09 ` Randy Dunlap
2013-04-04 14:41 ` Christoph Lameter
2013-04-04 16:28 ` Tejun Heo
2013-04-04 17:19 ` Randy Dunlap
2013-04-04 17:26 ` Tejun Heo
2013-04-04 17:40 ` Christoph Lameter
2013-04-04 18:35 ` Randy Dunlap
2013-04-04 18:52 ` Tejun Heo
2013-04-11 17:00 ` Paul E. McKenney
[not found] ` <alpine.DEB.2.02.1304031540110.3444@gentwo.org>
2013-04-03 20:42 ` [PERCPU] Remove & in front of this_cpu_ptr Christoph Lameter
2013-04-03 21:24 ` Tejun Heo
2013-04-03 21:29 ` Eric Dumazet
2013-04-04 13:52 ` Christoph Lameter
2013-04-04 14:00 ` Tejun Heo
2013-04-04 14:21 ` Christoph Lameter
2013-04-04 14:25 ` Tejun Heo
2013-04-04 15:02 ` Christoph Lameter
2013-04-04 14:29 ` Eric Dumazet
2013-03-29 19:13 ` [PATCH] core: fix the use " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364833887.5113.161.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=cl@linux.com \
--cc=davidshan@tencent.com \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox