Netdev List
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: Matthew O'Connor <liquidhorse@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3.0-longterm] bonding: ARP packet fix for balance-ALB (mode=6)
Date: Mon, 01 Apr 2013 19:14:21 +0100	[thread overview]
Message-ID: <1364840061.3557.109.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <CAK8PzVnNfLSnvxY83z3Em3gtJM4zWM0Xd4P3CWy3xt=7feJgMA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]

On Mon, 2013-04-01 at 12:36 -0400, Matthew O'Connor wrote:
> Do not modify or load balance ARP packets passing through balance-alb
> mode (wherein the ARP did not originate locally, and arrived via a bridge).
> 
> This patch is backported from the upstream commit:
>     From 567b871e503316b0927e54a3d7c86d50b722d955 Mon Sep 17 00:00:00 2001
>     Subject: [PATCH] bonding: rlb mode of bond should not alter ARP
> originating via bridge
> 
> Signed-off-by:  Matthew O'Connor <liquidhorse@gmail.com>
[...]

These patches are tab-damaged and word-wrapped.  See
Documentation/email-clients.txt

You should also use the conventional format for backported patches.
Keep the original commit message, but above it add:

    From: original author <address@domain>

    commit 567b871e503316b0927e54a3d7c86d50b722d955 upstream.

The commit reference could also be written in David Miller's favoured
format:

    [ Upstream commit 567b871e503316b0927e54a3d7c86d50b722d955 ]

If you have made substantial changes then explain them at the end of the
commit message with clear attribution to yourself.  You could add some
explanation below the '---' of why this is important to include in a
stable update.

Lastly, this should be cc'd to all the addresses on the original commit
(From, Cc, and Signed-off-by).

Ben.

-- 
Ben Hutchings
DNRC Motto:  I can please only one person per day.
Today is not your day.  Tomorrow isn't looking good either.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      reply	other threads:[~2013-04-01 18:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01 16:36 [PATCH 3.0-longterm] bonding: ARP packet fix for balance-ALB (mode=6) Matthew O'Connor
2013-04-01 18:14 ` Ben Hutchings [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364840061.3557.109.camel@deadeye.wl.decadent.org.uk \
    --to=ben@decadent.org.uk \
    --cc=liquidhorse@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox