From: Cong Wang <amwang@redhat.com>
To: roy.qing.li@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH Resend] core: should call pskb_expand_head if skb header is cloned in skb_gso_segment in rx path
Date: Tue, 02 Apr 2013 20:32:47 +0800 [thread overview]
Message-ID: <1364905967.22165.4.camel@cr0> (raw)
In-Reply-To: <1364783861-3363-1-git-send-email-roy.qing.li@gmail.com>
On Mon, 2013-04-01 at 10:37 +0800, roy.qing.li@gmail.com wrote:
> From: Li RongQing <roy.qing.li@gmail.com>
>
> 12b0004d1d1 (adjust skb_gso_segment() for calling in rx path) tries to kill warnings
> by checking if ip_summed is CHECK_NONE or not in rx path, since if skb_gso_segment()
> is called on rx path, and ->ip_summed has different meaning.
>
> but this maybe break skb if skb header is cloned, and not expand the header, since when
> step into skb_mac_gso_segment(), which will still check ip_summed with CHECKSUM_PARTIAL,
> then do gso_send_check(). and after __skb_gso_segment() in queue_gso_packets() of
> openvswitch, queue_userspace_packet() still checks ip_summed with CHECKSUM_PARTIAL,
> and do checksum.
>
> so I think it is enough to ignore the warning in rx path.
>
Did you see any bogus warning triggered by it?
BTW, please Cc all the people involved in the original commit you
mentioned above.
next prev parent reply other threads:[~2013-04-02 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 2:37 [PATCH Resend] core: should call pskb_expand_head if skb header is cloned in skb_gso_segment in rx path roy.qing.li
2013-04-02 12:32 ` Cong Wang [this message]
2013-04-03 0:51 ` RongQing Li
2013-04-03 1:19 ` Eric Dumazet
2013-04-03 1:44 ` RongQing Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364905967.22165.4.camel@cr0 \
--to=amwang@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).