From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: vfalico@redhat.com, netdev@vger.kernel.org,
stephen@networkplumber.org, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next] bridge: remove a redundant synchronize_net()
Date: Tue, 02 Apr 2013 09:27:57 -0700 [thread overview]
Message-ID: <1364920077.5113.185.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130402.121223.496337697838525487.davem@davemloft.net>
On Tue, 2013-04-02 at 12:12 -0400, David Miller wrote:
> Note that we have a few spots now that do two synchronize_net()'s per
> opertaion, such as team port removal, and openvswitch has such a path
> as well. They all are of the form:
>
> netdev_rx_handler_unregister()
> ...
> lots of other stuff
> ...
> synchronize_net();
>
> So might be harder to factor back out than this br_if.c case.
>
Strange, I do see call_rcu() in openvswitch, not a synchronize_{net|
rcu}(). Probably OK to leave as is, as it's not a big deal.
I'll let Jiri handle the team driver change, as its not clear what
synchronize_rcu() call in team_port_del() is protecting
next prev parent reply other threads:[~2013-04-02 16:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 15:45 [PATCH net-next] bridge: remove a redundant synchronize_net() Eric Dumazet
2013-04-02 15:58 ` Veaceslav Falico
2013-04-02 16:12 ` David Miller
2013-04-02 16:27 ` Eric Dumazet [this message]
2013-04-02 18:19 ` David Miller
2013-04-04 15:35 ` Jiri Pirko
2013-04-04 15:44 ` Eric Dumazet
2013-04-04 16:03 ` Eric Dumazet
2013-04-04 16:08 ` Jiri Pirko
2013-04-04 16:07 ` Jiri Pirko
2013-04-04 16:18 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364920077.5113.185.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox