Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Cc: Shiraz HASHIM <shiraz.hashim@st.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Deepak Sikri <deepak.sikri@st.com>,
	sergei.shtylyov@cogentembedded.com
Subject: Re: [net-next.git 2/7] stmmac: review barriers
Date: Thu, 04 Apr 2013 08:08:14 -0700	[thread overview]
Message-ID: <1365088094.13853.67.camel@edumazet-glaptop> (raw)
In-Reply-To: <515D1863.2070801@st.com>

On Thu, 2013-04-04 at 08:06 +0200, Giuseppe CAVALLARO wrote:

> In fact, if we can demonstrate that barriers are needed no problem to
> keep them in the code. Otherwise I prefer to remove them.
> 
> What do you think?

I think there are needed, and its really obvious.

Now maybe your arch can define wmb() as a pure compiler barrier(), but
thats a completely different patch.

  reply	other threads:[~2013-04-04 15:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03  5:41 [net-next.git 1/7] stmmac: review napi gro support Giuseppe CAVALLARO
2013-04-03  5:41 ` [net-next.git 2/7] stmmac: review barriers Giuseppe CAVALLARO
2013-04-03  7:18   ` Eric Dumazet
2013-04-03  7:28     ` Giuseppe CAVALLARO
2013-04-03  8:51   ` Shiraz Hashim
2013-04-04  6:06     ` Giuseppe CAVALLARO
2013-04-04 15:08       ` Eric Dumazet [this message]
2013-04-03 14:02   ` Sergei Shtylyov
2013-04-03  5:41 ` [net-next.git 3/7] stmmac: review private structure fields Giuseppe CAVALLARO
2013-04-03  7:21   ` Eric Dumazet
2013-04-03  7:33     ` Giuseppe CAVALLARO
2013-04-03 16:09       ` Ben Hutchings
2013-04-04  6:11         ` Giuseppe CAVALLARO
2013-04-03  5:41 ` [net-next.git 4/7] stmmac: review driver documentation Giuseppe CAVALLARO
2013-04-03  5:41 ` [net-next.git 5/7] stmmac: improve/review and fix kernel-doc Giuseppe CAVALLARO
2013-04-03  5:41 ` [net-next.git 6/7] stmmac: code tidy-up Giuseppe CAVALLARO
2013-04-03  5:41 ` [net-next.git 7/7] stmmac: prefetch all dma_erx when use extend_desc Giuseppe CAVALLARO
2013-04-03  7:05 ` [net-next.git 1/7] stmmac: review napi gro support Eric Dumazet
2013-04-03  7:41   ` Giuseppe CAVALLARO
2013-04-03 13:39     ` Eric Dumazet
2013-04-04  6:16       ` Giuseppe CAVALLARO
2013-04-03 16:01 ` Ben Hutchings
2013-04-04  6:20   ` Giuseppe CAVALLARO

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365088094.13853.67.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=deepak.sikri@st.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=shiraz.hashim@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox